samples: drivers: mbox: Allow coverage calculation #76415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-piks
added a commit
to nordic-piks/sdk-zephyr
that referenced
this pull request
Jul 30, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
nordicjm
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Jul 30, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
carlocaione
previously approved these changes
Jul 31, 2024
gmarull
previously approved these changes
Aug 5, 2024
Member
|
hey, this needs a rebase |
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
nordic-piks
force-pushed
the
enable_coverage_from_mbox_sample
branch
from
432ef5f to
dea05e9
Compare
Contributor
Author
Done, thanks. |
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Aug 20, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
carlocaione
approved these changes
Aug 22, 2024
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 9, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 10, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 10, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 10, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 10, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 10, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 10, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 10, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 10, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
bjarki-andreasen
approved these changes
Sep 10, 2024
Contributor
|
@nordic-piks I am confused by all the PRs recently that are "polluting" (for the last of a better word) the code samples with coverage boilerplate. Can you clarify what's your intent with this please? |
kartben
requested changes
Sep 10, 2024
Contributor
kartben
left a comment
kartben
left a comment
There was a problem hiding this comment.
Temporary NACK until question/concern above is addressed
nashif
requested changes
Sep 10, 2024
Member
nashif
left a comment
nashif
left a comment
There was a problem hiding this comment.
samples are samples, not tests. Adding this type of code to samples just defeats the purpose of samples. If you want covoerage, introduce a test for this drivers or convert this into a test.
bjarki-andreasen
pushed a commit
to bjarki-andreasen/sdk-zephyr
that referenced
this pull request
Sep 11, 2024
The sample must end to dump coverage data. Stop receiving to prevent callback from interrupting coverage dump. Upstream PR: zephyrproject-rtos/zephyr#76415 Signed-off-by: Piotr Kosycarz <piotr.kosycarz@nordicsemi.no>
Contributor
Author
|
I agree with your comments, will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample must end to dump coverage data.
Stop receiving to prevent callback from interrupting coverage dump.