Skip to content

soc: nordic: nrf53: SOC_NRF53_CPUNET_ENABLE should not depend on !BT #79875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

soc: nordic: nrf53: SOC_NRF53_CPUNET_ENABLE should not depend on !BT #79875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions soc/nordic/nrf53/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ config SOC_NRF53_CPUNET_MGMT

config SOC_NRF53_CPUNET_ENABLE
bool "NRF53 Network MCU is enabled at boot time"
depends on !BT
default y if NRF_802154_SER_HOST
select SOC_NRF53_CPUNET_MGMT
select SOC_NRF_GPIO_FORWARDER_FOR_NRF5340 if \
Expand All @@ -197,7 +196,6 @@ config BOARD_ENABLE_CPUNET
bool "[DEPRECATED] NRF53 Network MCU is enabled at boot time"
select SOC_NRF53_CPUNET_ENABLE
select DEPRECATED
depends on !BT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is deprecated, why is it being changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to restore it's functionality to the commit before it was deprecated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you aware that this will be removed at some point because it is deprecated? Does all code ported to the new order work without any changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kconfig is not used anywhere. So it is fine we change it here or leave it.

help
Use SOC_NRF53_CPUNET_ENABLE instead.

Expand Down
Loading