Skip to content

twister: fixes to statistics and counting, reduce platform scan verbosity #81129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmahadevan108 merged 14 commits into from
Nov 13, 2024
Merged

twister: fixes to statistics and counting, reduce platform scan verbosity #81129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0915aa3
twister: count filtered testcases as such, not as skipped
nashif Nov 7, 2024
397f9a4
twister: use consistent language for test configurations
nashif Nov 7, 2024
2679d17
twister: do not report filtered cases in summary
nashif Nov 7, 2024
42d067e
twister: stats: not run tests are also part not executed summary
nashif Nov 7, 2024
1768a8b
twister: remove verbose debug message about adding platforms
nashif Oct 30, 2024
2b9f4cd
twister: status inconsistencies are now warnings
nashif Nov 8, 2024
aa3853c
twister: stats: 'Executed test cases' -> 'Completed test cases'
nashif Nov 8, 2024
4dcbef3
twisters: tests: adapt twister testsuite
nashif Nov 9, 2024
e8d4b4b
twister: stats: remove double counting of statuses
nashif Nov 9, 2024
8434acb
twister: stats: skipped testcases are part of selected group
nashif Nov 10, 2024
52c724d
twister: stats: skipped_configs -> filtered_configs
nashif Nov 11, 2024
49be09c
twister: stats: more renames skipped -> filtered
nashif Nov 11, 2024
cc7e42e
twister: stats: fix suite statistics
nashif Nov 11, 2024
6c3a3fa
twister: stats: use anytree to create summary
nashif Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions scripts/pylib/twister/twisterlib/reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,19 +584,19 @@ def summary(self, results, ignore_unrecognized_sections, duration):
if float(handler_time) > 0:
run += 1

if results.total and results.total != results.skipped_configs:
pass_rate = (float(results.passed) / float(results.total - results.skipped_configs))
if results.total and results.total != results.filtered_configs:
pass_rate = (float(results.passed) / float(results.total - results.filtered_configs))
else:
pass_rate = 0

logger.info(
f"{TwisterStatus.get_color(TwisterStatus.FAIL) if failed else TwisterStatus.get_color(TwisterStatus.PASS)}{results.passed}"
f" of {results.total - results.skipped_configs}{Fore.RESET}"
f" of {results.total - results.filtered_configs}{Fore.RESET}"
f" executed test configurations passed ({pass_rate:.2%}),"
f" {f'{TwisterStatus.get_color(TwisterStatus.NOTRUN)}{results.notrun}{Fore.RESET}' if results.notrun else f'{results.notrun}'} built (not run),"
f" {f'{TwisterStatus.get_color(TwisterStatus.FAIL)}{results.failed}{Fore.RESET}' if results.failed else f'{results.failed}'} failed,"
f" {f'{TwisterStatus.get_color(TwisterStatus.ERROR)}{results.error}{Fore.RESET}' if results.error else f'{results.error}'} errored,"
f" with {f'{Fore.YELLOW}{self.plan.warnings}{Fore.RESET}' if self.plan.warnings else 'no'} warnings"
f" with {f'{Fore.YELLOW}{self.plan.warnings + results.warnings}{Fore.RESET}' if (self.plan.warnings + results.warnings) else 'no'} warnings"
f" in {duration:.2f} seconds."
)

Expand All @@ -615,16 +615,15 @@ def summary(self, results, ignore_unrecognized_sections, duration):
f'{", " + str(results.none_cases) + " without a status" if results.none_cases else ""}'
f' on {len(self.filtered_platforms)} out of total {total_platforms} platforms ({platform_rate:02.2f}%).'
)
if results.skipped_cases or results.filtered_cases or results.notrun_cases:
if results.skipped_cases or results.notrun_cases:
logger.info(
f'{results.skipped_cases + results.filtered_cases} selected test cases not executed:' \
f'{results.skipped_cases + results.notrun_cases} selected test cases not executed:' \
f'{" " + str(results.skipped_cases) + " skipped" if results.skipped_cases else ""}' \
f'{(", " if results.skipped_cases else " ") + str(results.filtered_cases) + " filtered" if results.filtered_cases else ""}' \
f'{(", " if results.skipped_cases or results.filtered_cases else " ") + str(results.notrun_cases) + " not run (built only)" if results.notrun_cases else ""}' \
f'{(", " if results.skipped_cases else " ") + str(results.notrun_cases) + " not run (built only)" if results.notrun_cases else ""}' \
f'.'
)

built_only = results.total - run - results.skipped_configs
built_only = results.total - run - results.filtered_configs
logger.info(f"{Fore.GREEN}{run}{Fore.RESET} test configurations executed on platforms, \
{TwisterStatus.get_color(TwisterStatus.NOTRUN)}{built_only}{Fore.RESET} test configurations were only built.")

Expand Down
Loading
Loading