Skip to content

Conversation

@mubinsyed
Copy link

Existing logic is passing elf file as parameter only when fsbl or bit file parameter is present. This is incorrect, elf file should be always passed irrespective of other parameters.

@zephyrbot zephyrbot added area: West West utility size: XS A PR changing only a single line of code labels Feb 12, 2025
@github-actions
Copy link

Hello @mubinsyed, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@pdgendt
Copy link
Contributor

pdgendt commented Feb 12, 2025

@kedareswararao PTAL

@pdgendt
Copy link
Contributor

pdgendt commented Feb 12, 2025

@mubinsyed the tests will need to be adjusted too.

@mubinsyed
Copy link
Author

@mubinsyed the tests will need to be adjusted too.

sure, I will update tests

Existing logic is passing elf file as parameter only when fsbl
or bit file parameter is present. This is incorrect, elf file should
be always passed irrespective of other parameters.

Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com>
@kartben kartben added the bug The issue is a bug, or the PR is fixing a bug label Feb 14, 2025
@kartben kartben added this to the v4.1.0 milestone Feb 14, 2025
@kartben kartben merged commit 16d5d5e into zephyrproject-rtos:main Feb 14, 2025
41 checks passed
@github-actions
Copy link

Hi @mubinsyed!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

kedareswararao pushed a commit to Xilinx/zephyr-amd that referenced this pull request May 23, 2025
Existing logic is passing elf file as parameter only when fsbl
or bit file parameter is present. This is incorrect, elf file should
be always passed irrespective of other parameters.

Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com>
Link: zephyrproject-rtos/zephyr#85641
State: waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: West West utility bug The issue is a bug, or the PR is fixing a bug size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants