-
Notifications
You must be signed in to change notification settings - Fork 8.3k
west_commands: runners: Fix parameters passed to xsdb #85641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @mubinsyed, and thank you very much for your first pull request to the Zephyr project! |
|
@kedareswararao PTAL |
|
@mubinsyed the tests will need to be adjusted too. |
sure, I will update tests |
Existing logic is passing elf file as parameter only when fsbl or bit file parameter is present. This is incorrect, elf file should be always passed irrespective of other parameters. Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com>
|
Hi @mubinsyed! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Existing logic is passing elf file as parameter only when fsbl or bit file parameter is present. This is incorrect, elf file should be always passed irrespective of other parameters. Signed-off-by: Mubin Sayyed <mubin.sayyed@amd.com> Link: zephyrproject-rtos/zephyr#85641 State: waiting
Existing logic is passing elf file as parameter only when fsbl or bit file parameter is present. This is incorrect, elf file should be always passed irrespective of other parameters.