sd: mmc: Remove unwanted request to card for reading OCR content #86144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danieldegrasse
left a comment
danieldegrasse
left a comment
There was a problem hiding this comment.
Looking at the spec I agree the second CMD1 could cause issues. We should drop the LOG_ERR (or reduce it to a LOG_DBG) on line 130 though- I suppose that since MMC cards are queried last, this isn't really a big issue (as working SDIO and SDMMC cards should never make it to this code flow). I just would prefer that SDIO/SDMMC cards that fail initialization don't also have a "Failed to query card OCR" log from the MMC code included in the output
Contributor
Author
|
yeah, I will better change it into LOG_DBG. |
As part of the MMC card initialization sequence, CMD1 command send multiple times to the card, first time to identify the card type and second time to check the requested voltage window is supported or not. There is a chance that after issuing the CMD1 for first time, card will move to the ready state before issuing the CMD1 for second time. In this case, card will not respond to the CMD1 send for the second time as card is already moved to ready state and this leads to failures. Hence remove the separate card identification logic and call mmc_send_op_cond only once to check both supported voltage window and card type identification. Signed-off-by: Paul Alvin <alvin.paulp@amd.com>
AlvinPaul26
force-pushed
the
remove_send_op_cond
branch
from
4f4688e to
02e8113
Compare
danieldegrasse
approved these changes
Feb 25, 2025
decsny
approved these changes
Feb 26, 2025
kedareswararao
pushed a commit
to Xilinx/zephyr-amd
that referenced
this pull request
May 23, 2025
As part of the MMC card initialization sequence, CMD1 command send multiple times to the card, first time to identify the card type and second time to check the requested voltage window is supported or not. There is a chance that after issuing the CMD1 for first time, card will move to the ready state before issuing the CMD1 for second time. In this case, card will not respond to the CMD1 send for the second time as card is already moved to ready state and this leads to failures. Hence remove the separate card identification logic and call mmc_send_op_cond only once to check both supported voltage window and card type identification. Signed-off-by: Paul Alvin <alvin.paulp@amd.com> Message-ID: <20250221113857.2112-1-alvin.paulp@amd.com> Link: zephyrproject-rtos/zephyr#86144 State: waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the MMC card initialization sequence, CMD1 command send multiple times to the card, first time to identify the card type and second time to check the requested voltage window is supported or not. There is a chance that after issuing the CMD1 for first time, card will move to the ready state before issuing the CMD1 for second time. In this case, card will not respond to the CMD1 send for the second time as card is already moved to ready state and this leads to failures. Hence remove the separate card identification logic and call mmc_send_op_cond only once to check both supported voltage window and card type identification.