drivers: gpio: adp5585: fix wrong output register during pin configure #86658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ADP5585_GPO_OUT_MODE_A is used when configuring initial output during pin configuration, causing pins configured HIGH is incorrectly configured as open-drain. Replacing the reg with ADP5585_GPO_DATA_OUT fixes the issue. Signed-off-by: Chekhov Ma <chekhov.ma@nxp.com>
CkovMk
force-pushed
the
hotfix/adp5585-output-register
branch
from
b3ed3f4 to
e1a21a7
Compare
henrikbrixandersen
added
backport v3.7-branch
henrikbrixandersen
approved these changes
Mar 6, 2025
kartben
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ADP5585_GPO_OUT_MODE_A is wrongly used when configuring initial output during pin configuration, causing pins configured HIGH is incorrectly configured as open-drain. Replacing the reg with ADP5585_GPO_DATA_OUT fixes the issue.
This bug is present since Zephyr v3.7, and should be backported.