tests: Bluetooth: Classic: Add dedicated test case for no_blobs #88076
Conversation
github-actions
bot
added
area: Bluetooth
area: Bluetooth Classic
There was a problem hiding this comment.
This doesn't seem like a good solution, since the tests are not specific to platforms that require blobs, rather they're generically named, implying that they should be runnable on any platform supporting Bluetooth Classic. You also have native_sim listed as a supported platform, which definitely does not require any blobs. I'd also expect the BUILD_ONLY_NO_BLOBS to always be combined with ‘build_only: true‘ in the test definition.
@nashif is there any recommended way to handle situations like this?
@nashif do you have any comments/suggestions? |
|
@jhedberg Is it possible to make PR move forward? |
I tried asking for help on #pr-help a few days ago. Next option could be to add the dev-review label and discuss this in tomorrow's meeting. |
I added label |
|
Initial consensus from Bluetooth WG: define a separate test case for the blobs configuration |
lylezhu2012
dismissed stale reviews from MarkWangChinese and makeshi
via
9de1c65
lylezhu2012
force-pushed
the
tests_br_sdp_c_s_building_issue
branch
from
b732081 to
9de1c65
Compare
|
I added test cases @jhedberg , Please help review my changes. |
lylezhu2012
force-pushed
the
tests_br_sdp_c_s_building_issue
branch
from
9de1c65 to
64fe57d
Compare
lylezhu2012
changed the title
CONFIG_BUILD_ONLY_NO_BLOBS=y
lylezhu2012
force-pushed
the
tests_br_sdp_c_s_building_issue
branch
from
64fe57d to
656dabd
Compare
| harness: pytest | ||
| harness_config: | ||
| pytest_dut_scope: session | ||
| fixture: usb_hci |
There was a problem hiding this comment.
I'm curious, what does the harness information mean for a test that's only supposed to be built but never run?
There was a problem hiding this comment.
As I know, the test case with fixture will not be run.
There was a problem hiding this comment.
Sure, but what does it mean? The test case says build_only: true, so what use is the fixture definition?
There was a problem hiding this comment.
build_only: true and CONFIG_BUILD_ONLY_NO_BLOBS=y are only used for CI. For testing on hardware, all of these two tags need to be removed.
So I would like to keep all tags.
There was a problem hiding this comment.
Can't you use the generic test case then? You can use --force-platform (or -K) with twister to run it on another platform than what's explicitly listed.
There was a problem hiding this comment.
Do you mean the test case bluetooth.classic.sdp.client.no_blobs is only used to verify the building issue of the platform mimxrt1170_evk@B/mimxrt1176/cm7 by CI?
Thus the following tags need to be removed from the test case bluetooth.classic.sdp.client.no_blobs.
harness: pytest
harness_config:
pytest_dut_scope: session
fixture: usb_hci
And test case bluetooth.classic.sdp.client is used to run test the test case on hardware. Right?
There was a problem hiding this comment.
Removed harness and harness_config tags from test case bluetooth.classic.sdp.client.no_blobs
Add dedicated test case `bluetooth.classic.sdp.server.no_blobs` and `bluetooth.classic.sdp.client.no_blobs` with the extra argument `CONFIG_BUILD_ONLY_NO_BLOBS=y` and `build_only: true` to make sure the tests sdp_s and sdp_c can be passed by Zephyr CI. Fixes zephyrproject-rtos#88060. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
lylezhu2012
force-pushed
the
tests_br_sdp_c_s_building_issue
branch
from
656dabd to
d6882eb
Compare
5 participants
Add dedicated test case
bluetooth.classic.sdp.server.no_blobsandbluetooth.classic.sdp.client.no_blobswith the extra argumentCONFIG_BUILD_ONLY_NO_BLOBS=yandbuild_only: trueto make sure the tests sdp_s and sdp_c can be passed by Zephyr CI.Fixes #88060.