stm32: drivers: serial: prevent possible race condition #91370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: STM32
github-actions
bot
requested review from
FRASTM,
GeorgeCGV,
dcpleung,
erwango,
etienne-lms,
gautierg-st,
marwaiehm-st and
mathieuchopstm
etienne-lms
previously approved these changes
Jun 10, 2025
djiatsaf-st
force-pushed
the
fix_issue_76799
branch
from
60f6018 to
0c20c07
Compare
etienne-lms
previously approved these changes
Jun 11, 2025
djiatsaf-st
force-pushed
the
fix_issue_76799
branch
from
0c20c07 to
2669f08
Compare
djiatsaf-st
force-pushed
the
fix_issue_76799
branch
2 times, most recently
from
4831bb7 to
3b2e97d
Compare
etienne-lms
reviewed
Jun 12, 2025
Contributor
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
I missed something: commit message header line should state the commit relates the stm32 uart driver only, e.g.:
drivers: serial: stm32: prevent race condition
The async_user_callback could be triggered from both the DMA transfer complete interrupt and a k_work queue timeout. Since the timeout runs outside of an ISR context, it could be interrupted by the DMA ISR. This might leads to a race condition where both paths access and modify shared DMA buffer state (offset and length) simultaneously, causing data corruption or out-of-sequence processing. Introduces proper synchronization to prevent concurrent access to shared DMA buffer variables, ensuring consistent and reliable data handling. Signed-off-by: Fabrice DJIATSA <fabrice.djiatsa-ext@st.com>
djiatsaf-st
force-pushed
the
fix_issue_76799
branch
from
3b2e97d to
265b8fd
Compare
|
mathieuchopstm
approved these changes
Jun 12, 2025
gautierg-st
approved these changes
Jun 12, 2025
erwango
approved these changes
Jun 12, 2025
|
Yee-haw! Thanks everybody involved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism to prevent a possible race condition between the DMA interrupt and the timeout callback in async_user_callback
FIxes #76799