Add nxp edac driver #94111

yvesll · 2025-08-05T07:45:11Z

Added NXP's EDAC implementation based on EIM and ERM

github-actions · 2025-08-05T07:45:53Z

Hello @yvesll, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

decsny

Looks like a very good first PR. But can you explain why this Devicetree structure with 4(+?) nodes was chosen?

yvesll · 2025-08-09T03:24:29Z

Looks like a very good first PR. But can you explain why this Devicetree structure with 4(+?) nodes was chosen?

You are correct, the virtual edac node and independent eim channel binding are redundant here.
I will only keep erm for error reporting and eim for error injection.

sonarqubecloud · 2025-08-11T07:44:43Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

drivers/edac/edac_nxp.c

drivers/edac/edac_mcux_erm.c

dts/bindings/edac/nxp,erm.yaml

Holt-Sun · 2025-09-16T03:19:48Z

Quality Gate passed

Please fix the issue in "Quality Gate passed".

drivers/edac/Kconfig.mcux_erm

drivers/edac/edac_nxp.c

drivers/edac/edac_mcux_erm.c

drivers/edac/Kconfig.nxp_edac

decsny · 2025-10-23T13:59:31Z

@yvesll you might need to rebase to get past some twister bug

yvesll · 2025-10-23T14:30:36Z

@yvesll you might need to rebase to get past some twister bug

Sure, I will do this together with the support for MCXE31

drivers/edac/edac_mcux_erm.c

Holt-Sun · 2025-10-30T05:51:01Z

include/zephyr/drivers/edac/edac_mcux_erm.h

+/* Callback data provided to function passed to notify_cb_set */
+struct edac_nxp_callback_data {
+	/* Number of corrected errors */
+	uint8_t corr_err_count;


If the corr_err_count could exceed 255, then should use uint32_t.

It will not, ERM only use 8 bit for error counter.

Holt-Sun · 2025-10-30T05:59:20Z

drivers/edac/edac_mcux_erm.c

+
+static void edac_nxp_irq_0(const struct device *dev)
+{
+	IRQ_CONNECT(DT_INST_IRQ_BY_IDX(0, 0, irq), DT_INST_IRQ_BY_IDX(0, 0, priority), edac_nxp_isr,


Hardcode the irq to 2. Considering the update for all IRQ numbers

Suggested change

IRQ_CONNECT(DT_INST_IRQ_BY_IDX(0, 0, irq), DT_INST_IRQ_BY_IDX(0, 0, priority), edac_nxp_isr,

#include <zephyr/sys/util.h>

static void edac_nxp_irq_0(const struct device *dev)

{

IRQ_CONNECT(DT_INST_IRQ_BY_IDX(0, 0, irq), DT_INST_IRQ_BY_IDX(0, 0, priority), edac_nxp_isr,

DEVICE_DT_INST_GET(0), 0);

irq_enable(DT_INST_IRQ_BY_IDX(0, 0, irq));

IRQ_CONNECT(DT_INST_IRQ_BY_IDX(0, 1, irq), DT_INST_IRQ_BY_IDX(0, 1, priority), edac_nxp_isr,

DEVICE_DT_INST_GET(0), 0);

irq_enable(DT_INST_IRQ_BY_IDX(0, 1, irq));

}

#define ERM_IRQ_CONNECT_IDX(idx, n) \

do { \

IRQ_CONNECT(DT_INST_IRQ_BY_IDX(n, idx, irq), \

DT_INST_IRQ_BY_IDX(n, idx, priority), \

edac_nxp_isr, DEVICE_DT_INST_GET(n), 0); \

irq_enable(DT_INST_IRQ_BY_IDX(n, idx, irq)); \

} while (0)

static void edac_nxp_irq_0(const struct device *dev)

{

ARG_UNUSED(dev);

UTIL_LISTIFY(DT_INST_NUM_IRQS(0), ERM_IRQ_CONNECT_IDX, 0);

}

No platform has more than one erm/eim instance now. It only requires one instance as 31 channels is really enough for MCU.

include/zephyr/drivers/edac/edac_mcux_erm.h

Add edac driver for NXP's ERM and EIM peripherals. It can inject ECC error to specific channel within EIM and then report the error address, syndrome and count within ERM. Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>

Add eim, erm and edac instance for frdm_mcxa153, frdm_mcxn236, frdm_mcxn947, frdm_mcxe247 and frdm_mcxe31b. Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>

Decouple the edac sample with IBECC. Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>

Update the console log in readme to make it aligned with the actual output Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>

sonarqubecloud · 2025-10-31T08:36:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

zephyrbot added platform: NXP Drivers NXP Semiconductors, drivers area: Samples Samples platform: NXP NXP area: EDAC labels Aug 5, 2025

zephyrbot requested review from DerekSnell, EmilioCBen, JiafeiPan, MaochenWang1, PetervdPerk-NXP, bperseghetti, butok, dbaluta, decsny, dleach02, finikorg, kartben, manuargue, mmahadevan108 and nashif August 5, 2025 07:46

zephyrbot assigned finikorg Aug 5, 2025

decsny reviewed Aug 8, 2025

View reviewed changes

yvesll force-pushed the add-nxp-edac-driver branch from e694c25 to be74c15 Compare August 11, 2025 07:27

Holt-Sun reviewed Sep 16, 2025

View reviewed changes

drivers/edac/edac_nxp.c Outdated Show resolved Hide resolved

drivers/edac/edac_nxp.c Outdated Show resolved Hide resolved

drivers/edac/edac_mcux_erm.c Show resolved Hide resolved

dts/bindings/edac/nxp,erm.yaml Show resolved Hide resolved

yvesll force-pushed the add-nxp-edac-driver branch from be74c15 to 815fb39 Compare September 17, 2025 01:50

zephyrbot requested a review from decsny September 17, 2025 01:51

yvesll force-pushed the add-nxp-edac-driver branch from 815fb39 to 971b938 Compare September 18, 2025 07:32

decsny reviewed Sep 18, 2025

View reviewed changes

drivers/edac/Kconfig.mcux_erm Show resolved Hide resolved

drivers/edac/edac_nxp.c Outdated Show resolved Hide resolved

drivers/edac/edac_nxp.c Outdated Show resolved Hide resolved

drivers/edac/edac_nxp.c Show resolved Hide resolved

yvesll force-pushed the add-nxp-edac-driver branch from 971b938 to 57d53c8 Compare September 19, 2025 09:10

zephyrbot requested a review from decsny September 19, 2025 09:11

zejiang0jason reviewed Sep 29, 2025

View reviewed changes

drivers/edac/edac_mcux_erm.c Show resolved Hide resolved

drivers/edac/Kconfig.nxp_edac Outdated Show resolved Hide resolved

yvesll force-pushed the add-nxp-edac-driver branch from 57d53c8 to 84d39cd Compare October 9, 2025 07:46

zephyrbot added platform: NXP MCU area: Devicetree Bindings area: Boards/SoCs labels Oct 9, 2025

yvesll force-pushed the add-nxp-edac-driver branch from 84d39cd to c076c51 Compare October 29, 2025 09:13

yvesll mentioned this pull request Oct 29, 2025

Update eim erm for edac zephyrproject-rtos/hal_nxp#629

Open

Holt-Sun reviewed Oct 30, 2025

View reviewed changes

kartben requested changes Oct 30, 2025

View reviewed changes

include/zephyr/drivers/edac/edac_mcux_erm.h Show resolved Hide resolved

yvesll added 4 commits October 31, 2025 16:01

drivers: edac: Add NXP EDAC driver

58341a8

Add edac driver for NXP's ERM and EIM peripherals. It can inject ECC error to specific channel within EIM and then report the error address, syndrome and count within ERM. Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>

dts: nxp: add edac support for MCX platforms

149859b

Add eim, erm and edac instance for frdm_mcxa153, frdm_mcxn236, frdm_mcxn947, frdm_mcxe247 and frdm_mcxe31b. Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>

samples: edac: update the app to support more platforms

c6a8f72

Decouple the edac sample with IBECC. Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>

doc: Update edac shell sample's readme

cc5576b

Update the console log in readme to make it aligned with the actual output Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>

yvesll force-pushed the add-nxp-edac-driver branch from c076c51 to cc5576b Compare October 31, 2025 08:09

zephyrbot added the area: Linters label Oct 31, 2025

zephyrbot requested review from kartben and keith-zephyr October 31, 2025 08:11

-	IRQ_CONNECT(DT_INST_IRQ_BY_IDX(0, 0, irq), DT_INST_IRQ_BY_IDX(0, 0, priority), edac_nxp_isr,
+#include <zephyr/sys/util.h>
+static void edac_nxp_irq_0(const struct device *dev)
+{
+    IRQ_CONNECT(DT_INST_IRQ_BY_IDX(0, 0, irq), DT_INST_IRQ_BY_IDX(0, 0, priority), edac_nxp_isr,
+                DEVICE_DT_INST_GET(0), 0);
+    irq_enable(DT_INST_IRQ_BY_IDX(0, 0, irq));
+    IRQ_CONNECT(DT_INST_IRQ_BY_IDX(0, 1, irq), DT_INST_IRQ_BY_IDX(0, 1, priority), edac_nxp_isr,
+                DEVICE_DT_INST_GET(0), 0);
+    irq_enable(DT_INST_IRQ_BY_IDX(0, 1, irq));
+}
+#define ERM_IRQ_CONNECT_IDX(idx, n)                                                     \
+       do {                                                                             \
+               IRQ_CONNECT(DT_INST_IRQ_BY_IDX(n, idx, irq),                             \
+                           DT_INST_IRQ_BY_IDX(n, idx, priority),                        \
+                           edac_nxp_isr, DEVICE_DT_INST_GET(n), 0);                     \
+               irq_enable(DT_INST_IRQ_BY_IDX(n, idx, irq));                             \
+       } while (0)
+       static void edac_nxp_irq_0(const struct device *dev)
+{
+       ARG_UNUSED(dev);
+       UTIL_LISTIFY(DT_INST_NUM_IRQS(0), ERM_IRQ_CONNECT_IDX, 0);
+}

Add nxp edac driver #94111

Are you sure you want to change the base?

Add nxp edac driver #94111

Conversation

yvesll commented Aug 5, 2025

Uh oh!

github-actions bot commented Aug 5, 2025

Uh oh!

decsny left a comment

Choose a reason for hiding this comment

Uh oh!

yvesll commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 11, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Holt-Sun commented Sep 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

decsny commented Oct 23, 2025

Uh oh!

yvesll commented Oct 23, 2025

Uh oh!

Uh oh!

Holt-Sun Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

yvesll Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Holt-Sun Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

yvesll Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 31, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

yvesll commented Aug 9, 2025 •

edited

Loading