modem: at_shell: extract user pipe handling #96194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanYates
force-pushed
the
250918_modem_chat_extract
branch
from
fcd4c0b to
8fa3d05
Compare
zephyrbot
added
Release Notes
zephyrbot
requested review from
bjarki-andreasen,
cfriedt,
jhedberg,
kartben,
rerickson1 and
tomi-font
JordanYates
force-pushed
the
250918_modem_chat_extract
branch
from
8fa3d05 to
c8f822b
Compare
Extract the user pipe setup and claim/release logic so that it can be re-used by other software modules, if the AT shell is not used. Ideally the chat instance would live within the `modem_at_user_pipe.c` and be handed out by `modem_at_user_pipe_claim`, but the current chat API doesn't make this possible. Signed-off-by: Jordan Yates <jordan@embeint.com>
JordanYates
force-pushed
the
250918_modem_chat_extract
branch
from
c8f822b to
07130e8
Compare
|
bjarki-andreasen
approved these changes
Sep 18, 2025
rerickson1
approved these changes
Sep 18, 2025
jhedberg
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the user pipe setup and claim/release logic so that it can be re-used by other software modules, if the AT shell is not used. Ideally the chat instance would live within the
modem_at_user_pipe.cand be handed out bymodem_at_user_pipe_claim, but the current chat API doesn't make this possible.