-
Notifications
You must be signed in to change notification settings - Fork 8.1k
boards: pcbcupid : Add glyph c6 board #97029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: pcbcupid : Add glyph c6 board #97029
Conversation
This PR adds the vendor name to the vendor prefix list Signed-off-by: muhammed asif <asifp3104@gmail.com>
4cdcb3c
to
fb6f239
Compare
@mbolivar @rruuaanng Hi, Should I do something about the twister issue? It seems to be related to POSIX and espressif HAL. |
I have restarted your CI, if it still fails, you can try rebasing.
I have restarted your CI, if it still fails, you can try rebase branch. |
boards/pcbcupid/glyph_c6/board.yml
Outdated
@@ -0,0 +1,6 @@ | |||
board: | |||
name: glyph_c6 | |||
full_name: Glyph ESP32C6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
full_name: Glyph ESP32C6 | |
full_name: Glyph-C6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated as suggested.
Introducing the Glyph-C6, a super efficient microcontroller development board packed with features | ||
for your next IoT project! With the robust capabilities of the ESP32-C6 chip, the Glyph-C6 is | ||
designed to provide reliable performance and extensive connectivity options in a compact form factor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the Zephyr documentation so please don't copy paste marketing material verbatim when it's time is clearly geared towards being used on a product page.
Please either "cleanup" this paragraph or come up with a more neutral version of your own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kartben for your review. I have updated the documentation as suggested. I will keep it in mind for future PRs.
294012a
fb6f239
to
294012a
Compare
294012a
to
5dada29
Compare
This PR adds support for glyph c6 board based on esp32c6. Tested using blinky,hello world and button. Adapted from esp32c6_devkitc Signed-off-by: Muhammed Asif <asifp3104@gmail.com>
5dada29
to
7b738d8
Compare
|
setting a more relevant assignee (Espressif maintainer) as this is a new board |
This PR adds support for glyph c6 board based on esp32c6.
pcbcupid
to the vendor prefix list.The board documentation can be found at : https://learn.pcbcupid.com/boards/glyph-c6/overview