boards: add Arduino UNO Q #97118

facchinm · 2025-10-07T13:40:02Z

Uses an STM32U585 microcontroller.
Some drivers will need to be developed (led matrix, internal RPC)

fabiobaltieri · 2025-10-09T05:07:35Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+	status = "okay";
+	pinctrl-0 = <&i2c4_scl_pd12 &i2c4_sda_pd13>;
+	pinctrl-1 = <&i2c4_scl_pf14 &i2c4_sda_pf15>;
+	pinctrl-names = "default", "sleep"; /* TODO: sleep is jmisc mux */


may be worth explanding the comment, not very clear at the moment

We have connected the same CPU peripheral to multiple sets of pins and need a solution to choose which pinmux must be applied at runtime; the choice of sleep was just a helpful placeholder.
Converted to regular comments and will submit a separate PR to provide this functionality.

fabiobaltieri · 2025-10-09T05:10:04Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+	pinctrl-0 = <&spi2_sck_pb13
+		     &spi2_miso_pb14 &spi2_mosi_pb15 &spi2_nss_pb9>;
+	pinctrl-1 = <&spi2_sck_pd1
+		     &spi2_miso_pc2 &spi2_mosi_pc3>;


nit: that's a weird way to indent this, maybe do two per line? or use #92334 if you feel like trying it, worked well from what I've seen

Tried downloading the latest available dts-linter (0.3.0-beta.5), but it did not flag or correct those. Fixed them by hand 👍

fabiobaltieri · 2025-10-09T05:10:30Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+
+&gpiog {
+	status = "okay";
+};


missing eof newline, fix your editor

fabiobaltieri · 2025-10-09T05:13:26Z

boards/arduino/uno_q/board.cmake

+  # Flash merged TF-M + Zephyr binary
+  set_property(TARGET runners_yaml_props_target PROPERTY hex_file tfm_merged.hex)
+
+  if (CONFIG_HAS_FLASH_LOAD_OFFSET)


check the compliance error, this one is very uninsightful for some reasons but I think it's complaining about the space after the if

@rugeGerritsen can you take a look? The error only shows

boards/arduino/uno_q/board.cmake:8 CMakeStyle

fabiobaltieri · 2025-10-09T05:15:45Z

boards/arduino/uno_q/doc/img/arduino_uno_q.webp

this has to be under 100k or somehing, crop the whitespace and pass it through https://tinywebp.app/ or something

this has to be under 100k or somehing, crop the whitespace and pass it through tinywebp.app or something

maybe use this one? It has transparent background and has the merit of being an actual picture, not a 3d render with lots of stuff apparenlty being edited out

fabiobaltieri · 2025-10-09T05:16:24Z

boards/arduino/uno_q/doc/index.rst

+
+.. code-block:: console
+
+   adb forward tcp:3333 tcp:3333 && adb shell arduino-debug


fancy, I presume this has to be run from the application processor? May be worth expanding a bit on it, or maybe just like the official programming documentation

nashif · 2025-10-09T09:46:08Z

I wonder what the "Q" stands for

pillo79

Thanks @fabiobaltieri for the review, comments should be addressed.

pillo79 · 2025-10-09T13:33:19Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+	pinctrl-0 = <&spi2_sck_pb13
+		     &spi2_miso_pb14 &spi2_mosi_pb15 &spi2_nss_pb9>;
+	pinctrl-1 = <&spi2_sck_pd1
+		     &spi2_miso_pc2 &spi2_mosi_pc3>;


Tried downloading the latest available dts-linter (0.3.0-beta.5), but it did not flag or correct those. Fixed them by hand 👍

pillo79 · 2025-10-09T14:13:18Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

+	status = "okay";
+	pinctrl-0 = <&i2c4_scl_pd12 &i2c4_sda_pd13>;
+	pinctrl-1 = <&i2c4_scl_pf14 &i2c4_sda_pf15>;
+	pinctrl-names = "default", "sleep"; /* TODO: sleep is jmisc mux */


We have connected the same CPU peripheral to multiple sets of pins and need a solution to choose which pinmux must be applied at runtime; the choice of sleep was just a helpful placeholder.
Converted to regular comments and will submit a separate PR to provide this functionality.

pillo79 · 2025-10-09T14:21:11Z

Sorry for the noise, did a pretty bad rebase 👎

kylebonnici · 2025-10-09T14:52:49Z

I can confirm the the current sha 94c74f9 produced the right formatting

uno_q % dts-linter --formatFixAll                                                                        
✅  Searching for '**/*.{dts,dtsi,overlay}' in /Users/kylebonnici/workspace/personal/zephyr/boards/arduino/uno_q
✅ [1/4] arduino_uno_q_stm32u585xx_ns.dts is correctly formatted
✅ [2/4] arduino_uno_q.dts is correctly formatted
✅ [3/4] arduino_uno_q-common.dtsi is correctly formatted
✅ [4/4] arduino_r3_connector.dtsi is correctly formatted
✅  Processed 4 files
✅  All files passed formatting

@pillo79

Tried downloading the latest available dts-linter (0.3.0-beta.5), but it did not flag or correct those. Fixed them by hand 👍

I have tried the linter on c080801 and I got the diff see attached, can you share how you ran it so I can fix any issues present.

diff.patch

pillo79 · 2025-10-09T15:45:17Z

I have tried the linter on c080801 and I got the diff see attached, can you share how you ran it so I can fix any issues present.

diff.patch

Thanks for confirming! Then there is no issue. I guess we were both surprised that the lines Fabio highlighted :

zephyr/boards/arduino/uno_q/arduino_uno_q-common.dtsi

Lines 133 to 136 in c080801

    
           pinctrl-0 = <&spi2_sck_pb13 
        
           	     &spi2_miso_pb14 &spi2_mosi_pb15 &spi2_nss_pb9>; 
        
           pinctrl-1 = <&spi2_sck_pd1 
        
           	     &spi2_miso_pc2 &spi2_mosi_pc3>;

did not trigger any rewrite even if they definitely look ugly, but you confirmed they don't breach any existing rules.

Also, I'm not sure we want to enforce a reformat for those: it will be a pretty invasive change whatever direction is chosen (one per line, reflow to some width etc).

kylebonnici · 2025-10-09T15:59:05Z

I have tried the linter on c080801 and I got the diff see attached, can you share how you ran it so I can fix any issues present.
diff.patch

Thanks for confirming! Then there is no issue. I guess we were both surprised that the lines Fabio highlighted :

zephyr/boards/arduino/uno_q/arduino_uno_q-common.dtsi

Lines 133 to 136 in c080801

pinctrl-0 = <&spi2_sck_pb13

&spi2_miso_pb14 &spi2_mosi_pb15 &spi2_nss_pb9>;

pinctrl-1 = <&spi2_sck_pd1

&spi2_miso_pc2 &spi2_mosi_pc3>;

did not trigger any rewrite even if they definitely look ugly, but you confirmed they don't breach any existing rules.

Also, I'm not sure we want to enforce a reformat for those: it will be a pretty invasive change whatever direction is chosen (one per line, reflow to some width etc).

No there are no such rules in place at the moment. The only rules I am planning to add in the near future is to reflow when we exceed 100 char and only if we can physically split the line.

nordicjm · 2025-10-10T07:46:28Z

boards/arduino/uno_q/arduino_uno_q.dts

+		scratch_partition: partition@e0000 {
+			label = "image-scratch";
+			reg = <0x000e0000 DT_SIZE_K(64)>;
+		};


not a change request but swap using scratch should only be used if you have different sector sizes in one slot or between both slots

nordicjm · 2025-10-10T07:46:47Z

boards/arduino/uno_q/arduino_uno_q_defconfig

@@ -0,0 +1,11 @@
+# SPDX-License-Identifier: Apache-2.0
+
+# enable uart driver


capitalise first letters of comments and acronyms like UART

boards/arduino/uno_q/doc/img/arduino_uno_q.webp

erwango · 2025-10-13T15:43:27Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

Non blocking: Use of -common.dtsi file feels useless now.

I intentionally left this to simplify porting changes from the ST eval board, but yes, it has no other purpose now.

pillo79

v2:

removed support for TF/M
fixed Twister CI issues
all comments should be addressed

@nordicjm please update your review, thanks!

boards/arduino/uno_q/doc/img/arduino_uno_q.webp

pillo79 · 2025-10-13T19:41:04Z

boards/arduino/uno_q/arduino_uno_q-common.dtsi

I intentionally left this to simplify porting changes from the ST eval board, but yes, it has no other purpose now.

Uses an STM32U585 microcontroller. Some drivers will need to be developed (led matrix, internal RPC) Signed-off-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: Luca Burelli <l.burelli@arduino.cc>

Enable relevant Twister tests for the Arduino Uno Q board. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>

sonarqubecloud · 2025-10-14T15:33:01Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

facchinm requested a review from kartben October 7, 2025 13:40

zephyrbot added the area: Boards/SoCs label Oct 7, 2025

zephyrbot requested a review from pillo79 October 7, 2025 13:41

zephyrbot assigned pillo79 Oct 7, 2025

fabiobaltieri requested a review from nordicjm October 9, 2025 05:06

fabiobaltieri reviewed Oct 9, 2025

View reviewed changes

pillo79 force-pushed the unoq-pr branch from c080801 to e9bb3d6 Compare October 9, 2025 14:15

pillo79 reviewed Oct 9, 2025

View reviewed changes

zephyrbot requested review from KhiemNguyenT, danieldegrasse, de-nordic, decsny, duynguyenxa, jfischer-no, khoa-nguyen-18, rghaddab, soburi, thaoluonguw and thenguyenyf October 9, 2025 14:17

pillo79 force-pushed the unoq-pr branch from e9bb3d6 to f06281e Compare October 9, 2025 14:20

zephyrbot requested a review from pillo79 October 9, 2025 14:21

pillo79 force-pushed the unoq-pr branch from f06281e to 94c74f9 Compare October 9, 2025 14:26

thenguyenyf removed their request for review October 10, 2025 03:15

nordicjm requested changes Oct 10, 2025

View reviewed changes

pillo79 force-pushed the unoq-pr branch from 94c74f9 to f145cf7 Compare October 12, 2025 17:12

pillo79 force-pushed the unoq-pr branch from 0c408fc to 9bd9e17 Compare October 13, 2025 15:35

zephyrbot added area: Tests Issues related to a particular existing or missing test platform: STM32 ST Micro STM32 area: DAC Digital-to-Analog Converter area: UART Universal Asynchronous Receiver-Transmitter area: Samples Samples area: I2C labels Oct 13, 2025

zephyrbot requested review from dcpleung, erwango, martinjaeger, nashif and teburd October 13, 2025 15:37

pillo79 force-pushed the unoq-pr branch from 9bd9e17 to ba7c27b Compare October 13, 2025 15:38

erwango reviewed Oct 13, 2025

View reviewed changes

erwango previously approved these changes Oct 13, 2025

View reviewed changes

pillo79 reviewed Oct 13, 2025

View reviewed changes

nordicjm previously approved these changes Oct 14, 2025

View reviewed changes

fabiobaltieri previously approved these changes Oct 14, 2025

View reviewed changes

facchinm and others added 2 commits October 14, 2025 17:16

boards: add Arduino UNO Q

1dfa595

Uses an STM32U585 microcontroller. Some drivers will need to be developed (led matrix, internal RPC) Signed-off-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: Luca Burelli <l.burelli@arduino.cc>

arduino_uno_q: enable CI tests

f7a59af

Enable relevant Twister tests for the Arduino Uno Q board. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>

pillo79 dismissed stale reviews from fabiobaltieri, nordicjm, and erwango via f7a59af October 14, 2025 15:16

pillo79 force-pushed the unoq-pr branch from ba7c27b to f7a59af Compare October 14, 2025 15:16

zephyrbot requested review from erwango and pillo79 October 14, 2025 15:18

kartben approved these changes Oct 14, 2025

View reviewed changes

pillo79 approved these changes Oct 14, 2025

View reviewed changes

cfriedt merged commit fa69daa into zephyrproject-rtos:main Oct 14, 2025
20 checks passed


		.. code-block:: console

		adb forward tcp:3333 tcp:3333 && adb shell arduino-debug

		@@ -0,0 +1,11 @@
		# SPDX-License-Identifier: Apache-2.0

		# enable uart driver

boards: add Arduino UNO Q #97118

boards: add Arduino UNO Q #97118

Uh oh!

Conversation

facchinm commented Oct 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartben Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nashif commented Oct 9, 2025

Uh oh!

pillo79 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pillo79 commented Oct 9, 2025

Uh oh!

kylebonnici commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pillo79 commented Oct 9, 2025

Uh oh!

kylebonnici commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pillo79 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 14, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

kartben Oct 14, 2025 •

edited

Loading

kylebonnici commented Oct 9, 2025 •

edited

Loading

kylebonnici commented Oct 9, 2025 •

edited

Loading