Skip to content

Conversation

@ljq-ctrl
Copy link

@ljq-ctrl ljq-ctrl commented Nov 1, 2025

…m #97906

audio playback and capure, extend API in codec.h

@ljq-ctrl
Copy link
Author

ljq-ctrl commented Nov 1, 2025

download code from github very very slow.
Encountered a git problem that cannot be solved
I close the following PR and recommit it refrence
https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow

the old PR is:
driver:audio: sf32lb52x:Add onchip codec driver for sf32lb52x platform #97906

@ljq-ctrl ljq-ctrl changed the title driver:audio: sf32lb52x:Add onchip codec driver for sf32lb52x platfor… drivers: audio: sf32lb52x: audio codec driver Nov 1, 2025
- uart
- gpio
- watchdog
- audio-codec
Copy link
Contributor

@JarmouniA JarmouniA Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- audio-codec
- audio

it should be used as a tag for some test/sample, otherwise has no utility.
https://docs.zephyrproject.org/latest/develop/test/twister.html#board-configuration

Speaking of which, this driver has to be tested (or at least built) in CI.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to not make unrelated changes into a big commit, split changes into chunks as needed. Also, make sure CI passes and do not open new PRs.

@ljq-ctrl ljq-ctrl force-pushed the codec branch 8 times, most recently from 9625992 to 4f8250e Compare November 4, 2025 04:10
@ljq-ctrl ljq-ctrl requested a review from gmarull November 4, 2025 05:17
@ljq-ctrl ljq-ctrl force-pushed the codec branch 2 times, most recently from 466240d to 581e6c8 Compare November 15, 2025 08:15
@ljq-ctrl
Copy link
Author

work well with dma now

@ljq-ctrl ljq-ctrl marked this pull request as ready for review November 15, 2025 08:17
@zephyrbot zephyrbot added the area: DMA Direct Memory Access label Nov 15, 2025
@zephyrbot zephyrbot requested a review from teburd November 15, 2025 08:19
@ljq-ctrl ljq-ctrl force-pushed the codec branch 5 times, most recently from 7b5e71e to 6953241 Compare November 18, 2025 02:43
Add more callback in DMA processing, Fix DMA size bug.

Signed-off-by: Gang He <ganghe@sifli.com>
@gangheivt gangheivt force-pushed the codec branch 2 times, most recently from 2ed7f60 to a00b251 Compare November 24, 2025 06:33
@zephyrbot zephyrbot added the area: Samples Samples label Nov 24, 2025
@zephyrbot zephyrbot requested review from kartben and nashif November 24, 2025 06:35
Gang He and others added 5 commits November 24, 2025 14:37
Add audio codec device tree information for sf32lb52x.dtsi

Signed-off-by: Gang He <ganghe@sifli.com>
SF32LB52X audio HAL driver source code is not need in Zephyr driver.

Signed-off-by: Gang He <ganghe@sifli.com>
Support audio device that has both input and output function.

Signed-off-by: Gang He <ganghe@sifli.com>
Add audio codec in board device tree, including PA control pin.

Signed-off-by: Gang He <ganghe@sifli.com>
audio playback and capure, extend API in codec.h

Signed-off-by: ljq-ctrl <jiqunli@sifli.com>
@gangheivt gangheivt force-pushed the codec branch 4 times, most recently from 7a52b2e to a3b597d Compare November 24, 2025 07:18
Add audio loop back sample

Signed-off-by: Gang He <ganghe@sifli.com>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants