Bluetooth: Host: Add Shorter Connection Intervals #98901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Tests
zephyrbot
requested review from
HaavardRei,
PavelVPV,
Thalley,
alwa-nordic,
asbjornsabo,
babrsn,
cvinayak,
fredrikdanebjer,
hermabe,
jhedberg,
jthm-ot,
larsgk,
niym-ot,
rugeGerritsen and
sjanc
Thalley
dismissed
their stale review
I don't have any more blockers, but I'm also vary of approving this change before getting input from Johan
jhedberg
previously approved these changes
Nov 19, 2025
Contributor
|
@jhedberg, I see SonarCloud cancelled a check without a reason. I don't see a way to re-run. I'm guessing it's a infrastructure error on their side. Will we be able to merge anyway? |
Thalley
previously approved these changes
Nov 19, 2025
Contributor
Thalley
left a comment
Thalley
left a comment
There was a problem hiding this comment.
No blockers from me, and if we found anything to follow up on, we have plenty of time before the next release
Copilot finished reviewing on behalf of
Thalley
November 19, 2025 10:48
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
weeTike
dismissed stale reviews from Thalley, jhedberg, and alwa-nordic
via
1d1f062
KyraLengfeld
previously approved these changes
Nov 19, 2025
Thalley
previously approved these changes
Nov 19, 2025
This commit adds support for the Shorter Connection Intervals feature to the Bluetooth host. Signed-off-by: Timothy Keys <timothy.keys@nordicsemi.no>
Since Shorter Connection Intervals changes the unit that connection intervals can be represented in. It is necessary to change how they are stored and represented. This commit deprecates interval in favour of interval_us. Remove use of interval in internal bt_conn struct since it is no longer needed. Signed-off-by: Timothy Keys <timothy.keys@nordicsemi.no>
This adds support for Shorter Connection Interval commands in the bt shell. Signed-off-by: Timothy Keys <timothy.keys@nordicsemi.no>
alwa-nordic
approved these changes
Nov 19, 2025
|
jhedberg
approved these changes
Nov 19, 2025
KyraLengfeld
approved these changes
Nov 19, 2025
Thalley
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bluetooth: host: Add Shorter Connection Intervals support
This commit adds support for the Shorter Connection Intervals feature to
the Bluetooth host.
bluetooth: host: Add compatibility functions for conn interval with SCI
Since Shorter Connection Intervals changes the unit that connection
intervals can be represented in. It is therefore necessary to change how
they are stored and represented.
bluetooth: host: shell: Add SCI shell commands
This adds support for Shorter Connection Interval commands in the bt
shell.