Skip to content

[Backport v4.3-branch] drivers: flash: stm32 qspi: Make delayed data sampling configurable #99403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: v4.3-branch
Choose a base branch
from
Open

[Backport v4.3-branch] drivers: flash: stm32 qspi: Make delayed data sampling configurable #99403

wants to merge 3 commits into from
+14 −2

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Nov 14, 2025 •
edited by JarmouniA
Loading

Backport 40816a8~3..40816a8 from #98999.

Fixes #99099

@azo-trackunit @github-actions
dts: bindings: stm32 qspi: add ssht-enable property
29c2583 
This property allows to enable QSPI delayed data sampling (SSHIFT).

Signed-off-by: Adam Zotow <azo@trackunit.com>
(cherry picked from commit e545887)
@azo-trackunit @github-actions
boards: stm32: set ssht-enable property on all qspi dual-flash boards
5b974ad 
With ssht-enable property introduced in STM32 QSPI driver the delayed
data sampling (SSHIFT) got disabled for both dual and non-dual flash
configurations. Set ssht-enable property for dual flash boards
to reenable delayed data sampling.

Signed-off-by: Adam Zotow <azo@trackunit.com>
(cherry picked from commit 54b0c95)
@azo-trackunit @github-actions
drivers: flash: stm32 qspi: Make delayed data sampling configurable
8b35c7d 
The QSPI delayed data sampling (SSHIFT) is enabled by default. This
feature is configurable in both XSPI and OSPI drivers. Align with
these drivers and make the feature configurable for QSPI too.

Signed-off-by: Adam Zotow <azo@trackunit.com>
(cherry picked from commit 40816a8)
@github-actions github-actions bot added the Backport Backport PR and backport failure issues label Nov 14, 2025
@github-project-automation github-project-automation bot moved this to To do in Backports Nov 14, 2025
@JarmouniA JarmouniA closed this Nov 14, 2025
@github-project-automation github-project-automation bot moved this from To do to Done in Backports Nov 14, 2025
@JarmouniA JarmouniA reopened this Nov 14, 2025
@github-project-automation github-project-automation bot moved this from Done to Needs more info in Backports Nov 14, 2025
@JarmouniA JarmouniA added this to the v4.3.1 milestone Nov 14, 2025
@JarmouniA JarmouniA force-pushed the backport-98999-to-v4.3-branch branch from 59779ba to 8b35c7d Compare November 14, 2025 14:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

erwango
erwango previously approved these changes Nov 14, 2025
View reviewed changes
@erwango erwango dismissed their stale review November 14, 2025 14:37

Thinking about it: Should we update the migration notes, here as well ?

@JarmouniA
Copy link
Contributor

JarmouniA commented Nov 14, 2025

Should we update the migration notes, here as well ?

Maybe we can add a section for v4.3.1?

@jhedberg
Copy link
Member

jhedberg commented Nov 17, 2025

Should we update the migration notes, here as well ?

Maybe we can add a section for v4.3.1?

@kartben is there some recommendation/convention for such things?

@kartben
Copy link
Contributor

kartben commented Dec 3, 2025

Should we update the migration notes, here as well ?

Maybe we can add a section for v4.3.1?

Is it really going to require "migration" for users though? If they don't set the boolean property things will work like before?

@erwango
Copy link
Member

erwango commented Dec 4, 2025

Is it really going to require "migration" for users though? If they don't set the boolean property things will work like before?

Indeed. No doc update required.

@JarmouniA
Copy link
Contributor

JarmouniA commented Dec 4, 2025 •
edited
Loading

Is it really going to require "migration" for users though? If they don't set the boolean property things will work like before?

The original behavior (in v4.2.0) was that Sample Shifting was enabled on all dual-flash platforms at the driver level. Then it got enabled for all platforms in b147d78 (shipped in v4.3.0).
This patch is restoring the original v4.2.0 behavior, but only for in-tree boards. Hence out-of-tree v4.3.0 users upgrading to v4.3.1 need a migration entry to know to add the new DT property to their dual-flash out-of-tree board in order to restore the v4.2.0/4.3.0 "correct" behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwango erwango erwango approved these changes

@JarmouniA JarmouniA JarmouniA approved these changes

@cfriedt cfriedt Awaiting requested review from cfriedt

@de-nordic de-nordic Awaiting requested review from de-nordic

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@jhedberg jhedberg Awaiting requested review from jhedberg

@juickar juickar Awaiting requested review from juickar

@kartben kartben Awaiting requested review from kartben

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@rghaddab rghaddab Awaiting requested review from rghaddab

Assignees

@erwango erwango

Labels

area: Boards/SoCs area: Devicetree Bindings area: Flash Backport Backport PR and backport failure issues platform: STM32 ST Micro STM32 Release Notes To be mentioned in the release notes

Projects

Backports
Status: Needs more info

Milestone

v4.3.1

Development

Successfully merging this pull request may close these issues.

7 participants

@JarmouniA @jhedberg @kartben @erwango @zephyrbot @azo-trackunit