Skip to content

drivers: counter: lptmr: Fix get_pending_int wrong implementation #99784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhedberg merged 1 commit into from
Dec 5, 2025
Merged

drivers: counter: lptmr: Fix get_pending_int wrong implementation #99784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions drivers/counter/counter_mcux_lptmr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,8 @@ static uint32_t mcux_lptmr_get_pending_int(const struct device *dev)
{
const struct mcux_lptmr_config *config = dev->config;
uint32_t mask = LPTMR_CSR_TCF_MASK | LPTMR_CSR_TIE_MASK;
uint32_t flags;

flags = LPTMR_GetStatusFlags(config->base);

return ((flags & mask) == mask);
return (uint32_t)!!((config->base->CSR & mask) == mask);
Copy link
Contributor

@zejiang0jason zejiang0jason Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't match the commit message description:

The correct behavior is to check only the TCF
(Timer Compare Flag) to see if an interrupt is pending,
regardless of the TIE (Timer Interrupt Enable) status.
This commit updates the function to return the TCF flag
directly.

Copy link
Contributor Author

@ZhaoxiangJin ZhaoxiangJin Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message updated.

}

static uint32_t mcux_lptmr_get_top_value(const struct device *dev)
Expand Down
Loading