fix(Arguments): Fixed url generation when using array with enums as values

Author: philippe-bourdeau

composer.json

@@ -32,7 +32,10 @@
     "psr-4": {
       "ZEROSPAM\\Framework\\SDK\\": "src/",
       "ZEROSPAM\\Framework\\SDK\\Test\\Base\\": "tests/src/Base"
-    }
+    },
+    "files": [
+      "src/Utils/Helpers/array.php"
+    ]
   },
   "autoload-dev": {
     "psr-4": {

src/Request/Arguments/Stackable/SubKeyedArrayStackableRequestArg.php

@@ -10,6 +10,7 @@
 
 
 use ZEROSPAM\Framework\SDK\Request\Arguments\RequestArg;
+use ZEROSPAM\Framework\SDK\Utils\Contracts\PrimalValued;
 
 /**
  * Class SubKeyedArrayStackableRequestArg
@@ -44,6 +45,10 @@ public function getSubKey(): string
      */
     public function toPrimitive()
     {
-        return $this->value;
+        return array_map_r(function ($data) {
+            return $data instanceof PrimalValued
+                ? $data->toPrimitive()
+                : $data;
+        }, $this->value);
     }
 }

src/Utils/Helpers/array.php

@@ -0,0 +1,29 @@
+<?php
+/**
+ * Created by PhpStorm.
+ * User: pbb
+ * Date: 25/09/18
+ * Time: 2:51 PM
+ */
+
+if (!function_exists('array_map_r')) {
+
+    /**
+     * @param $callback
+     * @param $input
+     *
+     * @return array
+     */
+    function array_map_r($callback, $input)
+    {
+        $output = [];
+        foreach ($input as $key => $data) {
+            if (is_array($data)) {
+                $output[$key] = array_map_r($callback, $data);
+            } else {
+                $output[$key] = $callback($data);
+            }
+        }
+        return $output;
+    }
+}

tests/src/Tests/Argument/StackableArgumentTest.php

@@ -12,6 +12,7 @@
 use ZEROSPAM\Framework\SDK\Test\Base\Argument\SearchArgumentArray;
 use ZEROSPAM\Framework\SDK\Test\Base\Data\TestRequest;
 use ZEROSPAM\Framework\SDK\Test\Base\TestCase;
+use ZEROSPAM\Framework\SDK\Test\Tests\Utils\Obj\BasicEnum;
 
 class StackableArgumentTest extends TestCase
 {
@@ -105,6 +106,20 @@ public function testArrayStackableInUrl(): void
         $this->validateQuery($client, 'search[statusids][]=1', 'search[statusids][]=2');
     }
 
+    /**
+     *
+     */
+    public function testArrayStackableWithEnums(): void
+    {
+        $client = $this->preSuccess([]);
+
+        $request = new TestRequest();
+        $request->addArgument(new SearchArgumentArray('statusids', [BasicEnum::OTHER(), BasicEnum::TEST()]));
+        $client->getOAuthTestClient()
+               ->processRequest($request);
+        $this->validateQuery($client, 'search[statusids][]=other', 'search[statusids][]=test');
+    }
+
     /**
      *
      */