fix(EmptyRequest): Don't have a body for GET requests

Don't serialize STATIC properties of requests.

Author: Antoine Aflalo

src/Client/OAuthClient.php

@@ -274,10 +274,6 @@ public function processRequest(IRequest $request): IResponse
             $options[RequestOptions::HEADERS] = $headers;
         }
 
-        if (isset($options[RequestOptions::JSON]) && empty($options[RequestOptions::JSON])) {
-            unset($options[RequestOptions::JSON]);
-        }
-
         try {
             $response   = $this->guzzleClient->request($request->httpType()->getValue(), $request->toUri(), $options);
             $parsedData = JSONParsing::responseToJson($response);

src/Request/Api/BaseRequest.php

@@ -198,6 +198,12 @@ final public function requestType(): RequestType
      */
     public function requestOptions(): array
     {
+        /**
+         * Don't set any JSON if it's a get request
+         */
+        if ($this->requestType()->is(RequestType::HTTP_GET())) {
+            return [];
+        }
         $options = [
             RequestOptions::JSON => $this->toArray(),
         ];

src/Utils/Reflection/ReflectionUtil.php

@@ -142,9 +142,12 @@ public static function getAllProperties($class, $blacklist = [])
             return $properties;
         }
 
-        return array_filter($properties, function (\ReflectionProperty $property) use ($blacklist) {
-            return !in_array($property->name, $blacklist);
-        });
+        return array_filter(
+            $properties,
+            function (\ReflectionProperty $property) use ($blacklist) {
+                return !$property->isStatic() && !in_array($property->name, $blacklist);
+            }
+        );
     }
 
     /**

tests/src/Base/Request/NullableTestRequest.php

@@ -10,6 +10,7 @@
 
 use ZEROSPAM\Framework\SDK\Request\Api\HasNullableFields;
 use ZEROSPAM\Framework\SDK\Request\Api\WithNullableFields;
+use ZEROSPAM\Framework\SDK\Request\Type\RequestType;
 use ZEROSPAM\Framework\SDK\Test\Base\Data\Request\TestRequest;
 
 class NullableTestRequest extends TestRequest implements WithNullableFields
@@ -32,4 +33,15 @@ public function setNullField(?string $nullField)
 
         return $this;
     }
+
+    /**
+     * Type of request.
+     *
+     * @return RequestType
+     */
+    public function httpType(): RequestType
+    {
+        return RequestType::HTTP_POST();
+    }
+
 }