Skip to content

[Leads] - TypeError: e.dispatch(...).finally is not a function #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 10, 2025
Merged

[Leads] - TypeError: e.dispatch(...).finally is not a function #3743

merged 18 commits into from
Sep 10, 2025

Conversation

@geodem127
Copy link
Contributor

@geodem127 geodem127 commented Aug 26, 2025 •
edited
Loading

RCA:

  • fetchLeads didn't return values, breaking the promise chain.

FIX:

  • Added return sortedLeads and throw err in the action
  • Wrapped dispatch in Promise.resolve() to guarantee .finally exists

@geodem127 geodem127 linked an issue Aug 26, 2025 that may be closed by this pull request
TypeError: e.dispatch(...).finally is not a function #3515
Closed
@geodem127 geodem127 added the bug Something isn't working label Aug 26, 2025
@geodem127 geodem127 self-assigned this Aug 26, 2025
finnar-bin
finnar-bin reviewed Aug 27, 2025
View reviewed changes
@shrunyan shrunyan merged commit 83f23cc into dev Sep 10, 2025
1 check failed
@shrunyan shrunyan deleted the fix/3515-Leads-TypeError-finally-is-not-a-function branch September 10, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@finnar-bin finnar-bin finnar-bin approved these changes

@agalin920 agalin920 Awaiting requested review from agalin920

Assignees

@geodem127 geodem127

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: e.dispatch(...).finally is not a function

4 participants

@geodem127 @finnar-bin @shrunyan