This repository was archived by the owner on Feb 26, 2020. It is now read-only.
Install header during post-build rather than post-install.#399
Closed
tomprince wants to merge 1 commit intoopenzfs:masterfrom
Closed
Install header during post-build rather than post-install.#399tomprince wants to merge 1 commit intoopenzfs:masterfrom
tomprince wants to merge 1 commit intoopenzfs:masterfrom
Conversation
New versions of dkms clean up the build directory after installing.
tomprince
force-pushed
the
fix-dkms-header-install
branch
from
dace803 to
f5b713e
Compare
Contributor
|
@behlendorf I have tested this in a fresh Fedora 20 VM and I am confident that this fix is correct. Feel free to add your pick of my In particular, this changes the build system to move the autotools products and headers from |
behlendorf
pushed a commit
that referenced
this pull request
Oct 9, 2014
New versions of dkms clean up the build directory after installing. It appears that this was always intended, but had rm -rf "/path/to/build/*" (note the quotes), which prevented it from working. Also, the build step is already installing stuff into the directory where these files go, so installing our stuff there as part of build rather than install makes sense. Signed-off-by: Tom Prince <tom.prince@clusterhq.com> Signed-off-by: Richard Yao <ryao@gentoo.org> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #399
ryao
pushed a commit
to ryao/spl
that referenced
this pull request
Nov 29, 2014
New versions of dkms clean up the build directory after installing. It appears that this was always intended, but had rm -rf "/path/to/build/*" (note the quotes), which prevented it from working. Also, the build step is already installing stuff into the directory where these files go, so installing our stuff there as part of build rather than install makes sense. Signed-off-by: Tom Prince <tom.prince@clusterhq.com> Signed-off-by: Richard Yao <ryao@gentoo.org> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#399
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New versions of dkms clean up the build directory after installing.
It appears that this was always intended, but had
rm -rf "/path/to/build/*"(note the quotes), which prevented it from working.Also, the build step is already installing stuff into the directory where these files go, so installing our stuff there as part of build rather than install makes sense.