Skip to content

Revert "Handle zap_add() failures in mixed ... "#7416

Merged
behlendorf merged 1 commit intoopenzfs:masterfrom
tonyhutter:revert-fix
Apr 9, 2018
Merged

Revert "Handle zap_add() failures in mixed ... "#7416
behlendorf merged 1 commit intoopenzfs:masterfrom
tonyhutter:revert-fix

Conversation

@tonyhutter
Copy link
Copy Markdown
Contributor

Description

This reverts commit cc63068. That commit caused disappearing files in: #7401

Motivation and Context

Closes: #7401

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

This reverts commit cc63068.
That commit caused disappearing files in:
openzfs#7401

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#7401
@behlendorf behlendorf merged commit 4f30166 into openzfs:master Apr 9, 2018
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2018

Codecov Report

Merging #7416 into master will decrease coverage by 0.13%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7416      +/-   ##
==========================================
- Coverage   76.31%   76.17%   -0.14%     
==========================================
  Files         330      330              
  Lines      104279   104235      -44     
==========================================
- Hits        79583    79406     -177     
- Misses      24696    24829     +133
Flag Coverage Δ
#kernel 76.39% <90%> (+0.52%) ⬆️
#user 65.25% <100%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0d992...4c2143a. Read the comment docs.

tonyhutter added a commit that referenced this pull request Apr 10, 2018
This reverts commit cc63068.

Under certain circumstances this change can result in an ENOSPC
error when adding new files to a directory.  See #7401 for full
details.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Issue #7401
Closes #7416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unlistable and disappearing files

2 participants