-
Notifications
You must be signed in to change notification settings - Fork 1
feat: semantic conventions via Weaver #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@inge4pres what do you think about this approach? Mostly transfered as well from the Rust OTel approach. I saw that you also merged another approach to generated these. |
@hendriknielaender apologies for not seeing this earlier, just figured out now you did this PR beacuse I don't have yet filters on this repo 😅 Let me have a look, my approach is completely different but it's limited to regitry and much more complex to reason about because it gnerates code with I'll try it out and see the results and let you know 👍🏼 |
|
@hendriknielaender I've had time to review the project structure, how it works and the motivations. Here's a summary of differences with the approach I developed in the past weeks, and pros and cons that I found: Code generationThe approach in this PR based on Weaver definitely reconnects better with the OTel ecosystem than a custom generator I wrote. Maintaining less code is better in this case. ArchitectureWith this PR we lose the namespacing, all the attributes/entities are in a single file for all different folders. I see that all of these metadata are splatted in comments, and while this is addressing the DX in the IDE, it's not allowing for usage based on those metadata. SummaryThe proposed usage of Weaver is a good thing for the evolution of the semconv development in Zig.
Questions:
|
|
@hendriknielaender just so you know, I am trying to iterate on your PR to add the characteristics that i mentioned in my previous comment |
Signed-off-by: inge4pres <fgualazzi@gmail.com>
Signed-off-by: inge4pres <fgualazzi@gmail.com>
Signed-off-by: inge4pres <fgualazzi@gmail.com>
Signed-off-by: inge4pres <fgualazzi@gmail.com>
237d73e to
ae34a02
Compare
|
I rebased and updated with the type-system goodness that we have in main branch. |
That looks great. 🙏 Thanks for taking care of it. |
This PR introduces comprehensive Zig language support for OpenTelemetry semantic conventions, utilizing weaver template registry. The implementation includes:
• Complete template system for generating Zig source files from semantic convention specifications
• All four semantic convention modules:
attributes, metrics, resources and traces