update source query and avoid percent encoding urls when downloading from mirrors #469
Conversation
The `toString` function on `vscode.Uri` will aggressively apply percent encoding even if unnecessary for some character+component cases. This affects the `+` in the filename of nightly versions and the `=` in the query parameter. While it is valid to percent encode even if unnecessary, this can still lead to confusion about whether the url is valid if the reader is unfamiliar with the rules around percent encoding. There is no downside to just using `URL` instead of `vscode.Uri` so that we get more readable urls. This can be especially helpful if the encoded url happens to be shown to the extension user through the error message of an exception as an example.
Techatrix
changed the title
How about just |
|
Seems reasonable. Also has the benefit that it doesn't got out of sync if this repository is moved off github to a different provider. |
Techatrix
force-pushed
the
techatrix/mirror-url-encoding
branch
from
af3fa54 to
c73d4c1
Compare
|
@Techatrix I think there's a problem with the existing path component from in my case, the |
3 participants
The
toStringfunction onvscode.Uriwill aggressively apply percent encoding even if unnecessary for some character+component cases.This affects the
+in the filename of nightly versions and the=in the query parameter. While it is valid to percent encode even if unnecessary, this can still lead to confusion about whether the url is valid if the reader is unfamiliar with the rules around percent encoding.There is no downside to just using
URLinstead ofvscode.Uriso that we get more readable urls. This can be especially helpful if the encoded url happens to be shown to the extension user through the error message of an exception as an example.closes #468
I also updated
sourcequery parameter fromvscode-zigtogithub-ziglang-vscode-zigto be similar to what mlugg/setup-zig does.