Base64DecoderWithIgnore.calcSizeUpperBound cannot return an error

[marximimus]

No description provided.

[jedisct1]

If it doesn't, this is probably because it hasn't been implemented yet.

But if after skipping the ignored chars, the length is inconsistent with the required padding (for variants that require padding), I'd expect that function to return InvalidPadding as the comment suggests.

[marximimus]

I don't think this function should return InvalidPadding for any source_len. The source can consist entirely of ignored chars.

[marximimus]

I forgot to change the doc comment, tho. I'll fix it.

[jedisct1]

If the input contains only ignored characters, it returns 0.

However, if the input length is not valid for padded Base64 and cannot be decoded, then returning an error is expected.

This is trivial to fix: https://gist.github.com/jedisct1/8ea5328ff856a5350432d21f69b78153

So I would prefer to fix the root cause rather than introduce a different breaking change that doesn't really help applications.

[jedisct1]

Or that can be two different functions, one that just takes the length (but in that case, update the function comment) and another one that takes the string.

[marximimus]

I think those should be two separate functions.

[marximimus]

Base64Decoder has calcSizeUpperBound (which takes length) and calcSizeForSlice (which takes a slice).

[jedisct1]

Oh nice, I forgot about calcSizeForSlice.

In that case, can you just update the function description to reflect the change?