fix symlink path not being resolved in darwin #6503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Related #1128 |
Signed-off-by: Loris Cro <kappaloris@gmail.com>
LemonBoy
reviewed
Oct 2, 2020
| // the executable not a "real path" to the executable. | ||
| var symlink_path_buf: [MAX_PATH_BYTES]u8 = undefined; | ||
| var u32_len: u32 = MAX_PATH_BYTES; | ||
| const rc = std.c._NSGetExecutablePath(&symlink_path_buf, &u32_len); |
Contributor
There was a problem hiding this comment.
Since _NSGetExecutablePath first parameter is null-terminated and this is the only callsite can you change the signature in darwin.zig?
That'd also help to get rid of the ptrCast below
Member
Author
|
@LemonBoy is this what you meant? |
Signed-off-by: Loris Cro <kappaloris@gmail.com>
kubkon
reviewed
Oct 2, 2020
Signed-off-by: Loris Cro <kappaloris@gmail.com>
kubkon
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging the monster branch, Zig stopped working on my macOS machine. The problem was that I was invoking
zigthrough a symlink which made the procedure for finding the stdlib fail.