Support for Laravel Blade file extension #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zignd
requested changes
Nov 5, 2017
src/extension.ts
Outdated
|
|
||
| extensions.forEach((extension) => { | ||
| context.subscriptions.push( | ||
| provideCompletionItemsGenerator(extension, htmlRegex) |
Owner
There was a problem hiding this comment.
The same regex can't be applied to all the extensions.
Contributor
Author
There was a problem hiding this comment.
My bad, I didn’t spot that and will amend. Thanks.
Owner
|
Thanks for the contribution, but can you fix that mistake? |
Contributor
Author
|
Hi @zignd. Changes have now been implemented and jsx and html regex are applied to correct extensions. Please let me know if I missed anything. Thanks. |
zignd
approved these changes
Nov 6, 2017
Owner
|
Good to go now! I will release a new version with the change in a moment. |
|
Still got the same problem. Was it solved? What do I have to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #83