Fix radio probing broken by #485 #487
Merged
+38
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #487 +/- ##
=======================================
Coverage 99.92% 99.93%
=======================================
Files 51 51
Lines 4283 4286 +3
=======================================
+ Hits 4280 4283 +3
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
agners
approved these changes
Aug 22, 2022
agners
approved these changes
Aug 22, 2022
Closed
puddly
added a commit
that referenced
this pull request
Aug 22, 2022
* Fix radio probing broken by #485 (#487) * Use the same startup reset sequence during probing * Adjust unit test to catch errors like this in the future * Call `_startup_reset` within the CLI tools * Add support for tcp protocol Add tcp:// protocol to talk to EZSP radio via TCP/IP. Compared to the existing socket:// protocol this uses Python's loop.create_connection() instead of pyserial. In tests this makes `bellows info` to complete about 50x faster (measured after reset, from 0.6s to 0.012s). * Address isort Co-authored-by: puddly <32534428+puddly@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EZSP "running" flag was not set during probing after #485 and this was not caught by unit tests. This fixes both problems.