Skip to content

Conversation

@jeverley
Copy link
Contributor

@jeverley jeverley commented Dec 8, 2024

Proposed change

Addresses the bug raised #3597

Additional information

Following investigation of the errors documented in #3597 and feedback from @TheJulianJES in #3597 (comment) I've explicitly defined zcl_type for attributes documented using enums and validated that writes to the attribute now complete successfully without introducing further issues.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@codecov
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (97413e3) to head (e641c94).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3598   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files         323      323           
  Lines       10414    10414           
=======================================
  Hits         9351     9351           
  Misses       1063     1063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeverley jeverley force-pushed the lumi.sensor_occupy.agl1 branch from de5ed98 to e641c94 Compare December 8, 2024 19:06
@TheJulianJES TheJulianJES added the bugfix This PR fixes a bug label Dec 9, 2024
@TheJulianJES TheJulianJES changed the title Address incorrect attribute type error when changing Aqara FP1E presence sensor motion sensitivity Add zcl_type for Aqara FP1E sensor attributes Dec 9, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES merged commit a1f6378 into zigpy:dev Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants