Skip to content

Conversation

@dmulcahey
Copy link
Contributor

This PR is so I can track the structure and organization of combining ZHA and ZHAWS into a single lib. I'll open smaller PR's to get things merged once things settle

@codecov
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 89.00081% with 273 lines in your changes missing coverage. Please review.

Project coverage is 94.62%. Comparing base (636ad13) to head (f3c1e48).

Files with missing lines Patch % Lines
zha/websocket/client/helpers.py 69.92% 83 Missing ⚠️
zha/websocket/server/gateway_api.py 85.96% 32 Missing ⚠️
zha/websocket/client/client.py 81.87% 27 Missing ⚠️
zha/websocket/server/client.py 78.74% 27 Missing ⚠️
zha/websocket/client/model/messages.py 44.18% 24 Missing ⚠️
zha/websocket/server/gateway.py 83.63% 18 Missing ⚠️
zha/websocket/client/controller.py 89.05% 15 Missing ⚠️
zha/websocket/client/proxy.py 88.33% 7 Missing ⚠️
zha/websocket/server/api/platforms/lock/api.py 90.16% 6 Missing ⚠️
zha/websocket/server/api/platforms/light/api.py 87.80% 5 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #250      +/-   ##
==========================================
- Coverage   96.31%   94.62%   -1.69%     
==========================================
  Files          61      104      +43     
  Lines        9368    11489    +2121     
==========================================
+ Hits         9023    10872    +1849     
- Misses        345      617     +272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmulcahey dmulcahey force-pushed the dm/add-websocket-server branch from 727c37e to f3c1e48 Compare October 27, 2024 21:12
@dmulcahey dmulcahey closed this Oct 27, 2024
@dmulcahey dmulcahey deleted the dm/add-websocket-server branch November 25, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants