Fix version() command #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the inconvenience, the Bug is actually in the firmware wrongly assuming these 4 extra bytes for the request – which is not described in the protocol docs. I'll update the firmware tomorrow (so it accepts both variants to not mess around with existing setups). |
|
I just went by what deCONZ 2.5.80 was doing for version command and noticed it was sending those 4 bytes and assumed the doc was incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
0x26370x00firmware version has more strict requirements for command parsing and apparently deCONZ serial protocol documentation misses some of information dresden-elektronik/deconz-rest-plugin#3260 (comment)Fix the
version()command by sending additional four 0x00 bytes in the version requests.