Use NWK address mode for broadcasts #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #173 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 7 7
Lines 907 908 +1
=======================================
+ Hits 877 878 +1
Misses 30 30
Continue to review full report at Codecov.
|
Adminiuga
approved these changes
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed on my test network that "permit join" never actually flipped the "permit" bit in any router's beacon, no matter how many times I permitted joins. It turns out broadcasts aren't actually being sent as broadcasts!
Serial traffic shows that deCONZ uses
NWKaddressing when sending broadcasts, notGROUP.The oldest Conbee II firmware I can find is 0x26420700 from March 2019 and it exhibits the same behavior. This patch fixes broadcasts on both the current stable (0x26720700 from August 2021) and the old version.