Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_commands():
@pytest.mark.asyncio
async def test_command(api, monkeypatch):
def mock_api_frame(name, *args):
return mock.sentinel.api_frame_data
return mock.sentinel.api_frame_data, api._seq
api._api_frame = mock.MagicMock(side_effect=mock_api_frame)
api._uart.send = mock.MagicMock()

Expand All @@ -82,7 +82,7 @@ async def mock_fut():
@pytest.mark.asyncio
async def test_command_timeout(api, monkeypatch):
def mock_api_frame(name, *args):
return mock.sentinel.api_frame_data
return mock.sentinel.api_frame_data, api._seq
api._api_frame = mock.MagicMock(side_effect=mock_api_frame)
api._uart.send = mock.MagicMock()

Expand Down
10 changes: 5 additions & 5 deletions zigpy_deconz/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,27 +126,27 @@ def close(self):

async def _command(self, name, *args):
LOGGER.debug("Command %s %s", name, args)
self._seq = (self._seq % 255) + 1
data = self._api_frame(name, *args)
data, seq = self._api_frame(name, *args)
self._uart.send(data)
fut = asyncio.Future()
self._awaiting[self._seq] = fut
self._awaiting[seq] = fut
try:
return await asyncio.wait_for(fut, timeout=COMMAND_TIMEOUT)
except asyncio.TimeoutError:
LOGGER.warning("No response to '%s' command", name)
self._awaiting.pop(self._seq)
self._awaiting.pop(seq)
raise

def _api_frame(self, name, *args):
cmd_id, schema = TX_COMMANDS[name]
d = t.serialize(args, schema)
data = t.uint8_t(cmd_id).serialize()
self._seq = (self._seq % 255) + 1
data += t.uint8_t(self._seq).serialize()
data += t.uint8_t(0).serialize()
data += t.uint16_t(len(d) + 5).serialize()
data += d
return data
return data, self._seq

def data_received(self, data):
try:
Expand Down