Skip to content

Conversation

@Adminiuga
Copy link
Collaborator

Fixes #23 and #22 (comment)

S2B and older modules do not support ATCE1 command. If device replies with ERROR to ATCE1 command, make it a soft failure.

@Adminiuga Adminiuga force-pushed the fixes/s2b-at-cmd-fix branch from 12be9d4 to a977994 Compare February 13, 2019 21:27
@Adminiuga Adminiuga closed this Feb 13, 2019
@Adminiuga Adminiuga reopened this Feb 13, 2019
@Adminiuga Adminiuga merged commit 048269f into zigpy:master Feb 13, 2019
@coveralls
Copy link

coveralls commented Feb 13, 2019

Pull Request Test Coverage Report for Build 67

  • 89 of 89 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 60: 0.0%
Covered Lines: 485
Relevant Lines: 485

💛 - Coveralls

@Adminiuga Adminiuga deleted the fixes/s2b-at-cmd-fix branch February 19, 2019 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants