Add resetPassword method to UserRepository for password reset functionality
#314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigzagdev
commented
Jun 29, 2025
Owner
Author
zigzagdev
left a comment
zigzagdev
left a comment
There was a problem hiding this comment.
Self Review
- Validates user existence via UserId
- Hashes the password through PasswordHasherInterface abstraction
- Keeps domain logic separated from infrastructure concerns
- Error handling for missing user is in place
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new resetPassword method to the UserRepository to enable password resets by updating the user's hashed password in the database based on a validated reset token.
- Implements the resetPassword method in the repository
- Adds corresponding tests covering both successful and failure scenarios
- Updates the UserRepository interface to include the new method
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app/User/Infrastructure/Repository/UserRepository.php | Adds resetPassword implementation using a generic Exception if user is not found |
| src/app/User/Infrastructure/InfrastructureTest/UserRepository_resetPasswordTest.php | Provides tests for valid and invalid user password resets |
| src/app/User/Domain/RepositoryInterface/UserRepositoryInterface.php | Updates the interface to declare resetPassword |
| $userModel = $this->user->find($userId->getValue()); | ||
|
|
||
| if ($userModel === null) { | ||
| throw new Exception('User not found'); |
There was a problem hiding this comment.
Consider using a domain-specific exception (e.g., UserNotFoundException) instead of a generic Exception to improve error handling clarity.
Comment on lines
+89
to
+94
|
|
||
| $updatedUser = $this->user->find($this->user->id); | ||
|
|
||
| $this->assertTrue( | ||
| Hash::check($newPassword, $updatedUser->password) | ||
| ); |
There was a problem hiding this comment.
The code following the expected exception call in the invalid user test is unreachable; consider removing these assertions to clarify the test intent.
Suggested change
| $updatedUser = $this->user->find($this->user->id); | |
| $this->assertTrue( | |
| Hash::check($newPassword, $updatedUser->password) | |
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a
resetPasswordmethod to theUserRepositorythat updates the user's password based on their ID and a validated token. This method hashes the new password and updates it in the database.Implementation Details
UserIdException('User not found')PasswordHasherInterfaceto hash the new passwordupdate()method