The set type is no longer ordered in Python 3.7+, meaning that pmt ac… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions are no longer reproducible with non-zero seeds. Use fromkeys and list as a workaround (another solution would be ordered-set from PyPi). Note there are multiple other occurrences of sets remaining, which may cause ordering issues elsewhere - the same workaround could be applied to them if necessary.
Owner
|
Thanks @jproudlo for the contribution. |
Author
|
Thanks for the quick turnaround @zlorb . As a sanity check I've cloned the merged fork and checked it still passes my tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions are no longer reproducible with non-zero seeds (tested on Python 3.8). My suggested update uses fromkeys and list as a workaround (another solution would be ordered-set from PyPi).
Note there are multiple other occurrences of sets remaining, which may
cause ordering issues elsewhere - the same workaround could be applied to
them if necessary.
I've also extended the debug a little - large data structures are easier to read.