Trying to fix session locking problems on some server side storages #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bungle
commented
Jun 8, 2016
bungle
commented
- Removed unneccessary initializers
- added some locals
- fixed some global variable leaks
- adjusted session to only start when it is modified (in hopes to fix locking problems)
…al variable leaks, adjusted session to only start when it is modified (in hopes to fix locking problems).
|
so I and tested it again (have a netscaler lb fronting two nginx servers supported by two memcache instances); at first glance, everything seems to work - no hanging as an additional measure, I instrumented the lock and unlock code, and confirmed that the calls now are paired so looks good ... thx for the timely response - we appreciate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.