Skip to content

Conversation

@loechel
Copy link
Member

@loechel loechel commented Mar 6, 2017

No description provided.

@loechel loechel requested review from icemac and stephan-hof March 6, 2017 20:33
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason why to port this test. Before releasing RP 4 we will delete the old implementation, and its tests. Or did I miss something here?

@stephan-hof
Copy link
Member

I agree with @icemac.
As the comment said ast.parse is a core method so we don't have to test it.
I also don't see a reason why keeping the test for _niceParse.

However I could image that we add some tests with unicode strings (not in the ASCII range) passed to the transformer itself or when the print functions are tested.

@loechel
Copy link
Member Author

loechel commented Mar 12, 2017

Well It was just the idea to move all old tests into our new schema, thats why I also commented that so.

We should still test the old code to see if everything still works, when we move things around.

@icemac
Copy link
Member

icemac commented Mar 14, 2017

@loechel We are currently testing the old code using the old tests, see tox.ini. So I see no need to port these tests.

@loechel loechel closed this Mar 27, 2017
@icemac icemac deleted the port_unicode_tests branch April 7, 2017 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants