Adjust import code conventions in setup.cfg[isort] and applied #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm removing myself as a reviewer here. icemac and others are maintaining this project and I have no stake in it. Whatever you decide to do in this project is up to you as a group. |
icemac
requested changes
May 17, 2017
There was a problem hiding this comment.
This PR mixes up many different kinds changes:
- renaming the HTML coverage output directory
- documentation changes
- import changes
- new flake8 checks
- isort changes
I'd like to see individual PRs for these different problems you wish to solve. This one is too huge to review effectively and it is not possible to see which change in the configuration caused which change in the code. And there is a conflict with the master which seems to require a rebase of some changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes the Source Code of RestrictedPython consistent with the bespoken part at the Zope Sprint in Halle --> zopefoundation/AccessControl#33 (comment)
Should be squash merged after review.