Separate code quality checks #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 18, 2016 15:50
There is no need to run its checks on each environment.
It is not yet activated because there are way to many flake8 failures in this package.
icemac
force-pushed
the
separate-code-quality-checks
branch
from
bcd7771 to
75c375d
Compare
sallner
approved these changes
Nov 25, 2016
.travis.yml
Outdated
| - pip install tox coveralls coverage | ||
| script: | ||
| - tox -e py | ||
| - tox -e py,isort |
There was a problem hiding this comment.
Here we might also want a run of the flake8 testenv, or is there any specific reason not to do so?
There was a problem hiding this comment.
The reason is that this package contains tons of flake8 violations which I did not yet wanted to fix for this PR.
| @@ -1,13 +1,13 @@ | |||
| [tox] | |||
| envlist = coverage-clean,py{27,34,35,36,py},coverage-report | |||
| envlist = coverage-clean,py{27,34,35,36,py},coverage-report,isort | |||
There was a problem hiding this comment.
Flake8 is also not called as a standard testenv here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to run the code quality checks along with the unit tests for each environment.