Skip to content

Conversation

@sobolevn
Copy link
Contributor

@sobolevn sobolevn commented Oct 4, 2017

No description provided.

Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks! SVG is what the Travis UI offers by default now when you try to select a badge.

Of the 67 zopefoundation projects I have locally cloned, 64 of them currently refer to .png for travis CI, while only 3 use .svg:

$ grep 'https://travis-ci.org/.*.png' `find zope.* -name README.rst` | wc -l
      64
$ grep 'https://travis-ci.org/.*.svg' `find zope.* -name README.rst` | wc -l
       3

@sobolevn
Copy link
Contributor Author

sobolevn commented Oct 4, 2017

I use a bot written in elixir actually. It does pretty much the same:

  1. Finding bad icons
  2. Replacing it with svg ones

And sends pull requests as it was me. I am going to open-source it as soon as possible.

@mgedmin
Copy link
Member

mgedmin commented Oct 4, 2017

I'm not sure we want to deal with 60+ pull requests.

I've a directory with all of zopefoundation repos checked out. I can run a few shell one-liners and commit + push the change to all of them. (I've done a few updates like this before, e.g. to upgrade the included copy of bootstrap.py.)

What I don't have is the energy to come up with the correct shell one-liner to run today. ;)

@mgedmin mgedmin merged commit d9c5d5e into zopefoundation:master Oct 4, 2017
@sobolevn sobolevn deleted the patch-1 branch October 4, 2017 16:22
@sobolevn
Copy link
Contributor Author

sobolevn commented Oct 4, 2017

sed all the things! Thanks for the quick reaction!

@mgedmin
Copy link
Member

mgedmin commented Oct 5, 2017

cd ~/src/zopefoundation
ghcloneall 
grep -l https://travis-ci.org/.*.png */README.rst|cut -d/ -f1 > PACKAGES
wc -l PACKAGES  # => 73
grep -l https://travis-ci.org/.*.png */README.rst|xargs sed -i '/https:\/\/travis-ci.org\//s/[.]png/.svg/'
for p in $(cat PACKAGES); do (cd $p && echo + $p && git diff); done  # whoops zc.zodbwsgi is special
(cd zc.zodbwsgi && git checkout .)
grep -l https://travis-ci.org/.*.png */README.rst|xargs sed -i '/https:\/\/travis-ci.org\//s/[.]png/.svg/' --follow-symlinks
for p in $(cat PACKAGES); do (cd $p && echo + $p && git diff); done  # all ok
for p in $(cat PACKAGES); do (cd $p && git commit -am "Use SVG icon for Travis" && git push); done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants