Skip to content

Conversation

@JirkaAichler
Copy link
Contributor

Signed-off-by: JirkaAichler jiri.aichler@broadcom.com

Signed-off-by: JirkaAichler <jiri.aichler@broadcom.com>
Signed-off-by: JirkaAichler <jiri.aichler@broadcom.com>
@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #499 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   74.17%   74.13%   -0.04%     
==========================================
  Files         289      289              
  Lines        5506     5506              
  Branches      666      666              
==========================================
- Hits         4084     4082       -2     
  Misses       1261     1261              
- Partials      161      163       +2
Impacted Files Coverage Δ
...apiml/product/logging/ApimlDependencyLogHider.java 88.23% <0%> (-11.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 373a408...cc0ab7b. Read the comment docs.

Signed-off-by: JirkaAichler <jiri.aichler@broadcom.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

cucumberVersion = '1.2.5'
hamcrestVersion = '1.3'
javaxServletApiVersion = '3.1.0'
jacksonVersion = '2.9.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jackson isn't used anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is but this variable is redundant and never used. jacksonCoreVersion is used instead.

@plavjanik plavjanik merged commit dd91e39 into master Feb 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the protectors/pom branch February 10, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants