Skip to content

Conversation

@taban03
Copy link
Contributor

@taban03 taban03 commented Feb 21, 2020

Increase API ML code coverage (specifically in GW)

Benefits we would get by migrating to JUnit5 are explained here #479

Gateway has been fully migrated to JUnit5 (org.junit.jupiter.api), the other modules are using the Vintage package (part of the junit5 library) for backward compatibility with Junit4

@taban03 taban03 changed the title EE - Increase code coverage + migration to JUnit5 (WIP) EE - Increase code coverage + migration to JUnit5 Feb 21, 2020
@taban03 taban03 force-pushed the private/taban03/increase_code_coverage branch from 6f44ce3 to 57db24d Compare February 24, 2020 12:57
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #517 into master will decrease coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   76.84%   76.24%   -0.61%     
==========================================
  Files         305      299       -6     
  Lines        6064     5644     -420     
  Branches      726      674      -52     
==========================================
- Hits         4660     4303     -357     
+ Misses       1216     1160      -56     
+ Partials      188      181       -7
Impacted Files Coverage Δ
...in/java/org/zowe/apiml/product/web/HttpConfig.java 78.84% <0%> (-2.83%) ⬇️
...ity/common/config/AuthConfigurationProperties.java 94.11% <0%> (-1.54%) ⬇️
...discovery/metadata/MetadataTranslationService.java 97.14% <0%> (-1.04%) ⬇️
...ateway/security/service/AuthenticationService.java 91.42% <0%> (-0.4%) ⬇️
...urity/login/zosmf/ZosmfAuthenticationProvider.java 98.41% <0%> (-0.22%) ⬇️
...iml/security/common/token/TokenAuthentication.java 100% <0%> (ø) ⬆️
...zowe/apiml/gateway/routing/ApimlRoutingConfig.java 0% <0%> (ø) ⬆️
...teway/security/config/ComponentsConfiguration.java 0% <0%> (ø) ⬆️
...owe/apiml/security/common/token/QueryResponse.java 100% <0%> (ø) ⬆️
...gateway/security/config/SecurityConfiguration.java 0% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172695c...c3f6faa. Read the comment docs.

Ilkin Abdullayev added 7 commits February 25, 2020 13:37
Signed-off-by: Ilkin Abdullayev <ilkin.abdullayev@broadcom.com>
Signed-off-by: Ilkin Abdullayev <ilkin.abdullayev@broadcom.com>
Signed-off-by: Ilkin Abdullayev <ilkin.abdullayev@broadcom.com>
Signed-off-by: Ilkin Abdullayev <ilkin.abdullayev@broadcom.com>
Signed-off-by: Ilkin Abdullayev <ilkin.abdullayev@broadcom.com>
Signed-off-by: Ilkin Abdullayev <ilkin.abdullayev@broadcom.com>
Signed-off-by: Ilkin Abdullayev <ilkin.abdullayev@broadcom.com>
@ilkinabdullayev ilkinabdullayev force-pushed the private/taban03/increase_code_coverage branch from 9810faa to ac13cd3 Compare February 25, 2020 12:46
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #517 into master will increase coverage by 36.86%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #517       +/-   ##
===========================================
+ Coverage    39.1%   75.96%   +36.86%     
===========================================
  Files         299      301        +2     
  Lines        5644     5667       +23     
  Branches      674      676        +2     
===========================================
+ Hits         2207     4305     +2098     
+ Misses       3364     1182     -2182     
- Partials       73      180      +107
Impacted Files Coverage Δ
.../gateway/ws/WebSocketRoutedSessionFactoryImpl.java 0% <0%> (ø)
...l/gateway/ws/ServletSslContextFactoryProvider.java 0% <0%> (ø)
.../apiml/gateway/ws/WebSocketProxyServerHandler.java 43.37% <50%> (+43.37%) ⬆️
...gateway/controllers/GatewayHomepageController.java 93.93% <90.62%> (+93.93%) ⬆️
...ain/java/org/zowe/apiml/security/HttpsFactory.java 76.72% <0%> (+1.72%) ⬆️
.../zowe/apiml/gateway/ws/WebSocketRoutedSession.java 2.63% <0%> (+2.63%) ⬆️
...in/java/org/zowe/apiml/security/SecurityUtils.java 54.94% <0%> (+4.39%) ⬆️
...java/org/zowe/apiml/product/version/BuildInfo.java 5% <0%> (+5%) ⬆️
... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc46cd...43db050. Read the comment docs.

…verage' into private/taban03/increase_code_coverage

# Conflicts:
#	gateway-service/src/test/java/org/zowe/apiml/gateway/controllers/GatewayHomepageControllerTest.java
Signed-off-by: Jakub Balhar <jakub.balhar@broadcom.com>
Signed-off-by: Ilkin Abdullayev <ilkin.abdullayev@broadcom.com>
@ilkinabdullayev ilkinabdullayev force-pushed the private/taban03/increase_code_coverage branch from d43978c to 43db050 Compare February 26, 2020 11:40
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

65.1% 65.1% Coverage
0.0% 0.0% Duplication

@taban03 taban03 changed the title (WIP) EE - Increase code coverage in Gateway EE - Increase code coverage in Gateway Feb 26, 2020
@ilkinabdullayev ilkinabdullayev merged commit 9621a63 into master Feb 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the private/taban03/increase_code_coverage branch February 26, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants