Skip to content

Conversation

@1000TurquoisePogs
Copy link
Member

sso-auth is an app server security plugin that uses both zss and apiml. It is made for handling the apimlAuthenticationToken. I merged the zss-auth and apiml-auth code together to make it, so the tokenInjector code remains, and this change seems correct but needs to be tested first, because maybe with SSO the tokenInjector is not needed at all anymore.

Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com

…essary anymore.

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
@1000TurquoisePogs
Copy link
Member Author

@balhar-jakub
Copy link
Member

Do you need/want some help from our side?

@1000TurquoisePogs
Copy link
Member Author

I might need help verifying that this works, but I need to make a test build first. I'll update this with a link.

@1000TurquoisePogs 1000TurquoisePogs changed the title [WIP] switch to sso-auth instead of apiml-auth switch to sso-auth instead of apiml-auth May 11, 2020
@1000TurquoisePogs
Copy link
Member Author

I tested this by applying these changes to https://zowe.jfrog.io/zowe/libs-snapshot-local/org/zowe/1.11.0-PR-1349/zowe-1.11.0-pr-1349-2-20200511183139.pax which is the build where every other remaining piece of SSO is integrated (zowe/zowe-install-packaging#1349)
It works! tokenInjector is no longer needed and therefore is being removed from sso-auth.
Also, sso-auth appears to successfully make apiml-auth redundant, so I don't know what you want to do with that plugin but its not necessary anymore.

Copy link
Contributor

@jandadav jandadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants