-
Notifications
You must be signed in to change notification settings - Fork 69
switch to sso-auth instead of apiml-auth #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to sso-auth instead of apiml-auth #617
Conversation
…essary anymore. Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
|
You can find sso-auth at https://github.com/zowe/zlux-server-framework/tree/master/plugins/sso-auth |
|
Do you need/want some help from our side? |
|
I might need help verifying that this works, but I need to make a test build first. I'll update this with a link. |
|
I tested this by applying these changes to https://zowe.jfrog.io/zowe/libs-snapshot-local/org/zowe/1.11.0-PR-1349/zowe-1.11.0-pr-1349-2-20200511183139.pax which is the build where every other remaining piece of SSO is integrated (zowe/zowe-install-packaging#1349) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Kudos, SonarCloud Quality Gate passed!
|
sso-auth is an app server security plugin that uses both zss and apiml. It is made for handling the apimlAuthenticationToken. I merged the zss-auth and apiml-auth code together to make it, so the tokenInjector code remains, and this change seems correct but needs to be tested first, because maybe with SSO the tokenInjector is not needed at all anymore.
Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com