Make jjwt only a test dependency in ZAAS Client #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr Plavjanik <petr.plavjanik@broadcom.com>
plavjanik
changed the title
balhar-jakub
approved these changes
May 20, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
|
@plavjanik I am merging the PR. I have another one that I would like to create and don't want to do it before merging this change to ease the Jenkins load. Hope you don't mind. |
delete-merged-branch
bot
deleted the
protectors/zaas-client-remove-dependency
branch
|
Thanks, that was fast :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jjwt has been used as a
compiledependency causing troubles to applications that were using a different version of it.It was not used by zaas-client code but by tests so this PR changes it to
testCompile.Signed-off-by: Petr Plavjanik petr.plavjanik@broadcom.com