Skip to content

Create ApiMediationClient.isRegistered Interface #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 3, 2020
Merged

Create ApiMediationClient.isRegistered Interface #762

merged 16 commits into from
Aug 3, 2020

Conversation

@CarsonCook
Copy link
Contributor

@CarsonCook CarsonCook commented Jul 24, 2020 •
edited by anton-brezina
Loading

Description

Creates ApiMediationClient.isRegistered method that allows for extending code to test for successful registration with the Discovery Service.

Fixes #307

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

For more details about how should the code look like read the Contributing guideline

CarsonCook and others added 10 commits July 23, 2020 08:30
@CarsonCook
Create ApiMediationClient.isRegistered
cdc9a5d 
Uses EurekaClient.getInstanceRemoteStatus to test for registration with the Discovery Service.

Signed-off-by: Carson Cook <carson.cook@ibm.com>
@CarsonCook
Create test API endpoint in discoverable client
05d5ade 
Creates a new endpoint to test registration to the Discovery Service via the API Mediation Client.

Signed-off-by: Carson Cook <carson.cook@ibm.com>
@CarsonCook
Merge branch 'master' into user/carsoncook/isEurekaRegisteredWithDisc…
7cbf564 
…overyInterface
@CarsonCook
Remove unused config reader property
3c9bedf 
Signed-off-by: Carson Cook <carson.cook@ibm.com>
@CarsonCook
Merge branch 'master' of github.com:zowe/api-layer into user/carsonco…
be82525 
…ok/isEurekaRegisteredWithDiscoveryInterface
@CarsonCook
Merge branch 'user/carsoncook/isEurekaRegisteredWithDiscoveryInterfac…
a136c7b 
…e' of github.com:CarsonCook/api-layer into user/carsoncook/isEurekaRegisteredWithDiscoveryInterface
@CarsonCook
Merge branch 'user/carsoncook/isEurekaRegisteredWithDiscoveryInterfac…
99ca380 
…e' of github.com:CarsonCook/api-layer into user/carsoncook/isEurekaRegisteredWithDiscoveryInterface
@CarsonCook
Add tests for mediation client endpoint in discoverable client
f8342f0 
Signed-off-by: Carson Cook <carson.cook@ibm.com>
@CarsonCook
Merge branch 'user/carsoncook/isEurekaRegisteredWithDiscoveryInterfac…
878f01a 
…e' of github.com:CarsonCook/api-layer into user/carsoncook/isEurekaRegisteredWithDiscoveryInterface
@CarsonCook
Create ApiMediationService unit tests
4e059fd 
Signed-off-by: Carson Cook <carson.cook@ibm.com>
@CarsonCook CarsonCook requested a review from jandadav July 24, 2020 20:53
@jandadav
Copy link
Contributor

jandadav commented Jul 28, 2020 •
edited
Loading

Can you please fix the sonar smells? We try to minimize those.

@jandadav
Copy link
Contributor

Hi Carson, I am looking at the test you wrote to discoverable client. Am i correct to understand that you are trying to spin another Eureka client instance within Discoverable client and connect and disconnect it?

@CarsonCook
Copy link
Contributor Author

Hi Carson, I am looking at the test you wrote to discoverable client. Am i correct to understand that you are trying to spin another Eureka client instance within Discoverable client and connect and disconnect it?

Yes, the new endpoint has a separate Eureka instance within Discoverable client and registers a different dummy service, then un-registers it.

@anton-brezina anton-brezina linked an issue Jul 29, 2020 that may be closed by this pull request
Java enabler API provides function to query the status of the service registration #307
Closed
@CarsonCook
Replace hardcoded config with dynamic DC config
8bb38ff 
Signed-off-by: Carson Cook <carson.cook@ibm.com>
@CarsonCook
Fix code smell on tests with no assert
3bf41a3 
Signed-off-by: Carson Cook <carson.cook@ibm.com>
@CarsonCook
Merge branch 'master' of github.com:zowe/api-layer into user/carsonco…
ed7dc80 
…ok/isEurekaRegisteredWithDiscoveryInterface
@CarsonCook
Merge branch 'user/carsoncook/isEurekaRegisteredWithDiscoveryInterfac…
c9ba6c2 
…e' of github.com:CarsonCook/api-layer into user/carsoncook/isEurekaRegisteredWithDiscoveryInterface
@CarsonCook CarsonCook requested a review from jandadav July 30, 2020 16:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

84.6% 84.6% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

jandadav
jandadav approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@jandadav jandadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carson!

@jandadav jandadav merged commit 124376c into zowe:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jandadav jandadav jandadav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Java enabler API provides function to query the status of the service registration

3 participants

@CarsonCook @jandadav @zowe-robot