zulip: Update reaction_data type.
#653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoopThrough-i-j
added a commit
to LoopThrough-i-j/zulip
that referenced
this pull request
Feb 23, 2021
The `message_id` was made an `str` object because the request expected `Dict[str, str]`. The request is now casted to `Dict[str, Any]` to fix the issue and removed typecast of `message_id` to str. python-zulip-api reference: zulip/python-zulip-api#653
|
For both the PRs, you don't need to write the whole file name in the commit message. See https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages Something like |
Update `reaction_data` type in add_reaction and remove_reaction, from Dict[str, str] to Dict[str, Any]
LoopThrough-i-j
force-pushed
the
update-message_id-type
branch
from
0274ae1 to
5e7974f
Compare
LoopThrough-i-j
added a commit
to LoopThrough-i-j/zulip
that referenced
this pull request
Feb 23, 2021
The `message_id` was made an `str` object because the request expected `Dict[str, str]`. The request is now casted to `Dict[str, Any]` to fix the issue and removed typecast of `message_id` to str. python-zulip-api reference: zulip/python-zulip-api#653
|
Actually, I saw Anders Kaseorg doing this for single file changes, hence thought that could be a better practice for a single file commit. |
LoopThrough-i-j
added a commit
to LoopThrough-i-j/zulip
that referenced
this pull request
Feb 23, 2021
The `message_id` was made an `str` object because the request expected `Dict[str, str]`. The request is now casted to `Dict[str, Any]` to fix the issue and removed typecast of `message_id` to str. python-zulip-api reference: zulip/python-zulip-api#653
|
Posting the relevant discussion thread for future reference: https://chat.zulip.org/#narrow/stream/127-integrations/topic/msg.20id.20in.20add_emoji.20doc. |
timabbott
pushed a commit
to zulip/zulip
that referenced
this pull request
Feb 23, 2021
The `message_id` was made an `str` object because the request expected `Dict[str, str]`. The request is now casted to `Dict[str, Any]` to fix the issue and removed typecast of `message_id` to str. python-zulip-api reference: zulip/python-zulip-api#653
|
Merged, thanks @LoopThrough-i-j! |
MSurfer20
pushed a commit
to MSurfer20/zulip
that referenced
this pull request
Feb 24, 2021
The `message_id` was made an `str` object because the request expected `Dict[str, str]`. The request is now casted to `Dict[str, Any]` to fix the issue and removed typecast of `message_id` to str. python-zulip-api reference: zulip/python-zulip-api#653
LoopThrough-i-j
changed the title
reaction_data type.reaction_data type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
reaction_datatype in add_reaction andremove_reaction, from Dict[str, str] to Dict[str, Any]