Skip to content

api: Fail fast on UNAUTHORIZED/BAD_REQUEST in call_on_each_event. (Fixes #783) #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

api: Fail fast on UNAUTHORIZED/BAD_REQUEST in call_on_each_event. (Fixes #783) #882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions zulip/zulip/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,13 @@ def do_register() -> Tuple[str, int]:
# TODO: Make this use our backoff library
time.sleep(1)
continue
# Fail fast on clearly misconfigured clients to avoid silent retries.
if res.get("result") == "error":
code = res.get("code")
if code in ("UNAUTHORIZED", "BAD_REQUEST"):
# UNAUTHORIZED -> bad/expired credentials
# BAD_REQUEST -> invalid parameters (often bad narrow)
raise ZulipError(f"{code}: {res.get('msg', '')}")

if "error" in res["result"]:
if res["result"] == "http-error":
Expand Down