Skip to content

"Copy link to channel" in channel action sheet #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2025
Merged

"Copy link to channel" in channel action sheet #1766

merged 3 commits into from
Jul 29, 2025

Conversation

@sm-sayedi
Copy link
Collaborator

@sm-sayedi sm-sayedi commented Jul 29, 2025 •
edited
Loading

Note: The first two commits (7c31282 & 3e9b4de) are cherry-picked from #1762 to use the custom "link" icon.

Screenshots

Channel action sheet Copied link pasted
Copy link to channel Channel link pasted

Fixes: #1227

@sm-sayedi sm-sayedi added the maintainer review PR ready for review by Zulip maintainers label Jul 29, 2025
@sm-sayedi sm-sayedi requested a review from chrisbobbe July 29, 2025 16:19
chrisbobbe
chrisbobbe approved these changes Jul 29, 2025
View reviewed changes
Copy link
Collaborator

@chrisbobbe chrisbobbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Marking for Greg's review

@chrisbobbe chrisbobbe requested a review from gnprice July 29, 2025 18:23
@chrisbobbe chrisbobbe assigned gnprice and unassigned chrisbobbe Jul 29, 2025
@chrisbobbe chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Jul 29, 2025
@gnprice
Copy link
Member

gnprice commented Jul 29, 2025

Thanks! Looks good; merging.

@gnprice gnprice merged commit 373cfb7 into zulip:main Jul 29, 2025
1 check passed
@alya
Copy link
Collaborator

alya commented Jul 29, 2025 •
edited
Loading

@laurynmm Adding to your list of features to document. I expect #1762 will merge soon as well.

@laurynmm laurynmm mentioned this pull request Jul 30, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisbobbe chrisbobbe chrisbobbe approved these changes

@gnprice gnprice Awaiting requested review from gnprice

Assignees

@gnprice gnprice

Labels

integration review Added by maintainers when PR may be ready for integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Offer "Copy link to channel" in channel action sheet

4 participants

@sm-sayedi @gnprice @alya @chrisbobbe