page: Split empty-page placeholder messages into header and message
#1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following a new Figma frame that specifies larger text for the first part: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=11194-18392&m=dev
chrisbobbe
added
a-design
This was referenced Oct 24, 2025
|
The bigger text when we only have one sentence looks good to me. |
|
Thanks for the review! Also maybe worth mentioning: the graphics in the Figma are tracked as #1551. |
rajveermalviya
approved these changes
Oct 27, 2025
rajveermalviya
added
integration review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a new Figma frame that specifies larger text for the first part:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=11194-18392&m=dev
cc @alya @terpimost
👉 When there's just one thing to say (like "There are no messages here."), do we want that text to be big or small? I've chosen big, here, but that might not actually be intended in the Figma? Figma screenshot:
(This comes from rebasing/developing part of #1640.)
Note changed "the" to "a" on the "Direct messages" page.