Skip to content

emoji: Ensure consistent row height for plain text emoji theme. #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

emoji: Ensure consistent row height for plain text emoji theme. #1994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions lib/widgets/emoji_reaction.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,7 @@ class EmojiPickerListEntry extends StatelessWidget {
final EmojiCandidate emoji;

static const _emojiSize = 24.0;
static const _rowMinHeight = _emojiSize + 20;

void _onPressed() {
Navigator.pop(pageContext, emoji);
Expand Down Expand Up @@ -578,20 +579,22 @@ class EmojiPickerListEntry extends StatelessWidget {
: Colors.transparent),
child: Padding(
padding: const EdgeInsets.symmetric(horizontal: 8),
child: Row(spacing: 4, children: [
if (glyph != null)
Padding(
padding: const EdgeInsets.all(10),
child: glyph),
Flexible(child: Text(label,
maxLines: 2,
overflow: TextOverflow.ellipsis,
style: TextStyle(
fontSize: 17,
height: 18 / 17,
color: designVariables.textMessage)))
]),
));
child: ConstrainedBox(
constraints: const BoxConstraints(minHeight: _rowMinHeight),
child: Row(spacing: 4, children: [
if (glyph != null)
Padding(
padding: const EdgeInsets.all(10),
child: glyph),
Flexible(child: Text(label,
maxLines: 2,
overflow: TextOverflow.ellipsis,
style: TextStyle(
fontSize: 17,
height: 18 / 17,
color: designVariables.textMessage)))
]),
)));
}
}

Expand Down